Refactor: log4j-api-test to junit 5 #9
Conversation
Generated by gradle/develocity-actions |
Realtin
force-pushed
the
log4j-api-test_refactor_junit5
branch
2 times, most recently
from
9d64a78
to
4d0c11a
Compare
| @@ -123,6 +123,7 @@ public void testSerializationOfNonSerializableValue() throws Exception { | |||
| public void testDeserializationOfUnknownClass() throws Exception { | |||
| final SortedArrayStringMap original = new SortedArrayStringMap(); | |||
| original.putValue("a", "avalue"); | |||
| // org.junit.runner does not have an equivalent in junit 5 | |||
| original.putValue("serializableButNotInClasspathOfDeserializer", new org.junit.runner.Result()); | |||
There was a problem hiding this comment.
This is a part I just don't know how to fix. It seems to me as if they are just using the Result() function to generate a Serializable output. Maybe they need to rewrite this test.
|
All of a sudden I am now getting the Error locally when running the tests. Which seems to be cause by a loop maybe here: this used to only happen when I removed the junit dependency from the pom.xml file and replaced it with org.junit.vinatge. I talked to james about this error the other day and we did not have an idea how to figure out what is causing this. so we left it (since at the time I thought it only occurs with the junit.vinatge dependency which I could just not use) The other Build Actions will also fail (probably due to some timeout or Stackoverflow somewhere) :((( |
Realtin
force-pushed
the
log4j-api-test_refactor_junit5
branch
from
0760ff0
to
2b9940a
Compare
|
|
||
| @ParameterizedTest | ||
| @MethodSource("data") | ||
| public void testSerializationRoundtripEquals(Serializable serializable) { |
There was a problem hiding this comment.
oopsie, this should be final MessageFormatMessage message
Realtin
force-pushed
the
log4j-api-test_refactor_junit5
branch
from
2b9940a
to
4ca67e8
Compare
Realtin
force-pushed
the
log4j-api-test_refactor_junit5
branch
from
4ca67e8
to
b15b1e9
Compare
[A clear and concise description of what the pull request is for along with a reference to the associated issue IDs, if they exist.]
Checklist
2.xbranch if you are targeting Log4j 2; usemainotherwise./mvnw verifysucceeds (if it fails due to code formatting issues reported by Spotless, simply run./mvnw spotless:applyand retry)src/changelog/.2.x.xdirectory