Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Only collect .yml or .yaml files as workflow much earlier #2523

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ChristopherHX
Copy link
Contributor

GitHub Actions doesn't process non yaml files, since strict validation this doesn't make sense.

Copy link
Contributor

github-actions bot commented Nov 7, 2024

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ EDITORCONFIG editorconfig-checker 1 0 0.01s
✅ REPOSITORY gitleaks yes no 2.39s
✅ REPOSITORY git_diff yes no 0.01s
✅ REPOSITORY grype yes no 8.95s
✅ REPOSITORY secretlint yes no 1.09s
✅ REPOSITORY trivy-sbom yes no 0.12s
✅ REPOSITORY trufflehog yes no 3.3s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

Copy link

codecov bot commented Nov 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.01%. Comparing base (5a80a04) to head (9942f74).
Report is 128 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #2523       +/-   ##
===========================================
+ Coverage   61.56%   75.01%   +13.45%     
===========================================
  Files          53       62        +9     
  Lines        9002    10014     +1012     
===========================================
+ Hits         5542     7512     +1970     
+ Misses       3020     1936     -1084     
- Partials      440      566      +126     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ChristopherHX
Copy link
Contributor Author

TLDR, seems like non yml files are discarded later...

@ChristopherHX ChristopherHX changed the title fix: [BREAKING] Only load .yml or .yaml files as workflow fix: Only collect .yml or .yaml files as workflow much earlier Nov 7, 2024
@ChristopherHX ChristopherHX marked this pull request as ready for review November 7, 2024 22:01
@ChristopherHX ChristopherHX requested a review from a team as a code owner November 7, 2024 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant