Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add symbol address to pull request template #72

Merged
merged 1 commit into from
Aug 9, 2022

Conversation

YasunoriMATSUOKA
Copy link
Member

Link to ticket

  • no ticket

What you did

What did you do with this pull?

  • Add Symbol address to pull request template.

What you will not do

What you will not do with this pull request? (If any. If not, "none" is OK) (If not, state when you will do it or create the issue will be remained.)

  • none

What developers will be able to do (from the developer's perspective)

What will developers be able to do? (If any. (If not, "none" is OK.) ## What developer will be able to do (from the developer's perspective)

  • If the pull request is deemed reward-worthy and the pull request is filled out with the contributor's Symbol address, the contributor can be smoothly paid on the Symbol blockchain

What will not be possible (from the developer's perspective)

What will be impossible to do? (If available. If not, "None" is OK.) * What will be impossible to do? (If no, then "None" is OK.)

  • none

Operation check

What kind of operation checks were performed? What are the results?

  • none

Others

Reference information for reviewers (describe any implementation concerns or cautions)

  • none

@YasunoriMATSUOKA YasunoriMATSUOKA added the documentation Improvements or additions to documentation label Aug 8, 2022
@YasunoriMATSUOKA YasunoriMATSUOKA self-assigned this Aug 8, 2022
Copy link

@ymuichiro ymuichiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

少しマージリクエストが細かすぎではないでしょうか。

PRについては本文に変更の概要も書くべきだと思います

@YasunoriMATSUOKA
Copy link
Member Author

YasunoriMATSUOKA commented Aug 8, 2022

ご意見ありがとうございます。

細かくしている理由は、この後、外部の方々にてサンプルコードを書いて頂くようなIssueを刈り取って頂く際に、以下を意識しているからです。

  • できるだけ多くの方に貢献の機会を提供可能なように、小粒なIssueをそれなりの量で用意したいと考えているから。
  • 外部の方々にこれらのプルリクを参考にしてほしいと考えているから。
  • 外部の方に作成してもらったプルリクをレビューする際に、できるだけ小粒な機能ごとにプルリクを作ってもらって、無理の無い範囲で情報を書いておいてもらえるとレビューワーとしてはありがたいというこちらの意図を伝えたいという考えているから。

今後、本格的に実装すべき機能を実装していく際には、もう少し違った粒度になると思うので、一旦サンプルコード関連を進めていくところでは、こういったイメージで進めさせてもらえれば... と考えています。

プルリクのテンプレートに概要的な項目を追加すべきというのはおっしゃる通りかもしれないと感じました。typescript-axiosの方と合わせて、別途対応 #73 しようと思います。

@YasunoriMATSUOKA YasunoriMATSUOKA merged commit e859e9c into main Aug 9, 2022
@YasunoriMATSUOKA YasunoriMATSUOKA deleted the add-symbol-address-to-pull-request-template branch August 9, 2022 04:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Development

Successfully merging this pull request may close these issues.

2 participants