Skip to content

feat: packfiledirectory #235

feat: packfiledirectory

feat: packfiledirectory #235

Triggered via pull request October 14, 2024 23:00
Status Failure
Total duration 47s
Artifacts

check.yml

on: pull_request
nightly / fmt
12s
nightly / fmt
nightly / doc
33s
nightly / doc
ubuntu / nightly / features
23s
ubuntu / nightly / features
Matrix: clippy
Fit to window
Zoom out
Zoom in

Annotations

5 errors and 5 warnings
nightly / fmt
Process completed with exit code 1.
module `dat` is private: engine/src/asset/pack_file/directory.rs#L5
error[E0603]: module `dat` is private --> engine/src/asset/pack_file/directory.rs:5:61 | 5 | skybox::Skybox, string_table::StringTable, texture::dat::texture::Texture, AssetParser, | ^^^ ------- module `texture` is not publicly re-exported | | | private module | note: the module `dat` is defined here --> engine/src/asset/texture/mod.rs:1:1 | 1 | mod dat; | ^^^^^^^^
ubuntu / nightly / features
Process completed with exit code 1.
nightly / clippy
Clippy had exited with the 101 exit code
nightly / doc
Process completed with exit code 101.
the feature `duration_consts_float` has been stable since 1.84.0-nightly and no longer requires an attribute to enable: engine/src/lib.rs#L23
warning: the feature `duration_consts_float` has been stable since 1.84.0-nightly and no longer requires an attribute to enable --> engine/src/lib.rs:23:5 | 23 | duration_consts_float, | ^^^^^^^^^^^^^^^^^^^^^ | = note: `#[warn(stable_features)]` on by default
constants have by default a `'static` lifetime: engine/src/asset/pack_file/directory.rs#L72
warning: constants have by default a `'static` lifetime --> engine/src/asset/pack_file/directory.rs:72:17 | 72 | const ASSETS: [&'static str; 158] = [ | -^^^^^^^---- help: consider removing `'static`: `&str` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes = note: `#[warn(clippy::redundant_static_lifetimes)]` on by default
unused import: `ErrorKind as IoErrorKind`: engine/src/asset/pack_file/directory.rs#L12
warning: unused import: `ErrorKind as IoErrorKind` --> engine/src/asset/pack_file/directory.rs:12:10 | 12 | io::{ErrorKind as IoErrorKind, Result as IoResult}, | ^^^^^^^^^^^^^^^^^^^^^^^^ | note: the lint level is defined here --> engine/src/lib.rs:18:9 | 18 | #![warn(unused_imports)] | ^^^^^^^^^^^^^^
nightly / clippy
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
nightly / clippy
The following actions use a deprecated Node.js version and will be forced to run on node20: actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/