Skip to content

feat: packfiledirectory #249

feat: packfiledirectory

feat: packfiledirectory #249

Triggered via pull request October 30, 2024 03:36
Status Success
Total duration 37s
Artifacts

check.yml

on: pull_request
nightly / fmt
12s
nightly / fmt
nightly / doc
23s
nightly / doc
ubuntu / nightly / features
24s
ubuntu / nightly / features
Matrix: clippy
Fit to window
Zoom out
Zoom in

Annotations

7 warnings
docs for function returning `Result` missing `# Errors` section: ashen/src/asset/pack_file.rs#L28
warning: docs for function returning `Result` missing `# Errors` section --> ashen/src/asset/pack_file.rs:28:5 | 28 | pub fn new(input: &[u8]) -> Result<Self> { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_errors_doc = note: `#[warn(clippy::missing_errors_doc)]` implied by `#[warn(clippy::pedantic)]`
this expression creates a reference which is immediately dereferenced by the compiler: ashen/src/asset/pack_file/directory.rs#L231
warning: this expression creates a reference which is immediately dereferenced by the compiler --> ashen/src/asset/pack_file/directory.rs:231:62 | 231 | .filter(|(f, _)| recursive || f.parent() == Some(&path)) | ^^^^^ help: change this to: `path` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow = note: `#[warn(clippy::needless_borrow)]` on by default
the borrowed expression implements the required traits: ashen/src/asset/pack_file/directory.rs#L230
warning: the borrowed expression implements the required traits --> ashen/src/asset/pack_file/directory.rs:230:44 | 230 | .filter(|(f, _)| f.starts_with(&path)) | ^^^^^ help: change this to: `path` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default
this function has too many lines (165/100): ashen/src/asset/pack_file/directory.rs#L27
warning: this function has too many lines (165/100) --> ashen/src/asset/pack_file/directory.rs:27:5 | 27 | / pub fn from_106_packfile(pack: PackFile) -> Option<Self> { 28 | | let mut files = BTreeMap::new(); 29 | | 30 | | let copyright = pack.copyright.into_bytes().into_boxed_slice(); ... | 205 | | Some(Self { files }) 206 | | } | |_____^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_lines = note: `#[warn(clippy::too_many_lines)]` implied by `#[warn(clippy::pedantic)]`
docs for function which may panic missing `# Panics` section: ashen/src/asset/color_map.rs#L18
warning: docs for function which may panic missing `# Panics` section --> ashen/src/asset/color_map.rs:18:5 | 18 | pub fn from_12_bit(color: u16) -> Self { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | note: first possible panic found here --> ashen/src/asset/color_map.rs:20:9 | 20 | assert!(color <= 0xFFF, "12 bit color is smaller than 0xFFF"); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_panics_doc note: the lint level is defined here --> ashen/src/lib.rs:1:9 | 1 | #![warn(clippy::pedantic)] | ^^^^^^^^^^^^^^^^ = note: `#[warn(clippy::missing_panics_doc)]` implied by `#[warn(clippy::pedantic)]`
nightly / clippy
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
nightly / clippy
The following actions use a deprecated Node.js version and will be forced to run on node20: actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/