Feat/textures asset parser #159
nenikitovtest.yml
on: pull_request
ubuntu / nightly / direct-minimal-versions
43s
Matrix: os-check
Matrix: required
Annotations
8 errors and 6 warnings
|
windows-latest / nightly
Canceling since a higher priority waiting request for 'test-feat/textures-asset-parser' exists
|
|
windows-latest / nightly
The operation was canceled.
|
|
ubuntu / nightly / direct-minimal-versions
Canceling since a higher priority waiting request for 'test-feat/textures-asset-parser' exists
|
|
ubuntu / nightly / direct-minimal-versions
The operation was canceled.
|
|
ubuntu / nightly
Canceling since a higher priority waiting request for 'test-feat/textures-asset-parser' exists
|
|
ubuntu / nightly
The operation was canceled.
|
|
macos-latest / nightly
Canceling since a higher priority waiting request for 'test-feat/textures-asset-parser' exists
|
|
macos-latest / nightly
The operation was canceled.
|
|
this expression creates a reference which is immediately dereferenced by the compiler:
engine/src/asset/texture/dat/texture.rs#L52
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> engine/src/asset/texture/dat/texture.rs:52:64
|
52 | let (input, mip_4) = Texture::parser(&(&size / 8))(&input)?;
| ^^^^^^ help: change this to: `input`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
this expression creates a reference which is immediately dereferenced by the compiler:
engine/src/asset/texture/dat/texture.rs#L51
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> engine/src/asset/texture/dat/texture.rs:51:64
|
51 | let (input, mip_3) = Texture::parser(&(&size / 4))(&input)?;
| ^^^^^^ help: change this to: `input`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
this expression creates a reference which is immediately dereferenced by the compiler:
engine/src/asset/texture/dat/texture.rs#L50
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> engine/src/asset/texture/dat/texture.rs:50:64
|
50 | let (input, mip_2) = Texture::parser(&(&size / 2))(&input)?;
| ^^^^^^ help: change this to: `input`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
this expression creates a reference which is immediately dereferenced by the compiler:
engine/src/asset/texture/dat/texture.rs#L49
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> engine/src/asset/texture/dat/texture.rs:49:57
|
49 | let (input, mip_1) = Texture::parser(&size)(&input)?;
| ^^^^^^ help: change this to: `input`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
= note: `#[warn(clippy::needless_borrow)]` on by default
|
|
docs for function returning `Result` missing `# Errors` section:
engine/src/asset/pack_file.rs#L26
warning: docs for function returning `Result` missing `# Errors` section
--> engine/src/asset/pack_file.rs:26:5
|
26 | pub fn new(input: &[u8]) -> Result<Self> {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_errors_doc
= note: `#[warn(clippy::missing_errors_doc)]` implied by `#[warn(clippy::pedantic)]`
|
|
docs for function which may panic missing `# Panics` section:
engine/src/asset/color_map.rs#L17
warning: docs for function which may panic missing `# Panics` section
--> engine/src/asset/color_map.rs:17:5
|
17 | pub fn from_12_bit(color: u16) -> Self {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
note: first possible panic found here
--> engine/src/asset/color_map.rs:19:9
|
19 | assert!(color <= 0xFFF, "12 bit color is smaller than 0xFFF");
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_panics_doc
note: the lint level is defined here
--> engine/src/lib.rs:1:9
|
1 | #![warn(clippy::pedantic)]
| ^^^^^^^^^^^^^^^^
= note: `#[warn(clippy::missing_panics_doc)]` implied by `#[warn(clippy::pedantic)]`
|