refactor!: overhaul SoundAssetCollection.
#169
UserIsntAvailabletest.yml
on: pull_request
ubuntu / nightly / direct-minimal-versions
43s
Matrix: os-check
Matrix: required
Annotations
4 warnings
|
redundant closure:
engine/src/asset/sound/mod.rs#L56
warning: redundant closure
--> engine/src/asset/sound/mod.rs:56:32
|
56 | .map(|s| s.map(|s| Sound::Effect(s)));
| ^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `Sound::Effect`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
|
|
redundant closure:
engine/src/asset/sound/mod.rs#L48
warning: redundant closure
--> engine/src/asset/sound/mod.rs:48:32
|
48 | .map(|s| s.map(|s| Sound::Song(s)));
| ^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `Sound::Song`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
= note: `#[warn(clippy::redundant_closure)]` on by default
|
|
docs for function returning `Result` missing `# Errors` section:
engine/src/asset/pack_file.rs#L26
warning: docs for function returning `Result` missing `# Errors` section
--> engine/src/asset/pack_file.rs:26:5
|
26 | pub fn new(input: &[u8]) -> Result<Self> {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_errors_doc
= note: `#[warn(clippy::missing_errors_doc)]` implied by `#[warn(clippy::pedantic)]`
|
|
docs for function which may panic missing `# Panics` section:
engine/src/asset/color_map.rs#L17
warning: docs for function which may panic missing `# Panics` section
--> engine/src/asset/color_map.rs:17:5
|
17 | pub fn from_12_bit(color: u16) -> Self {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
note: first possible panic found here
--> engine/src/asset/color_map.rs:19:9
|
19 | assert!(color <= 0xFFF, "12 bit color is smaller than 0xFFF");
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_panics_doc
note: the lint level is defined here
--> engine/src/lib.rs:1:9
|
1 | #![warn(clippy::pedantic)]
| ^^^^^^^^^^^^^^^^
= note: `#[warn(clippy::missing_panics_doc)]` implied by `#[warn(clippy::pedantic)]`
|