Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/better mixer #50

Merged
merged 88 commits into from
Oct 12, 2024
Merged

Feat/better mixer #50

merged 88 commits into from
Oct 12, 2024

Conversation

nenikitov
Copy link
Owner

No description provided.

@nenikitov
feat: start adding flags
fd1586a
@nenikitov
wip: remake the mixer
7472e27
@nenikitov
wip: add proper bpm
04dbb51
@nenikitov
wip: making sustain instruments
eaa8d3e
@nenikitov
wip: make instrument take a reference to sample
2135955
@nenikitov
refactor: use reference instead of indexes
642aab9
@nenikitov
refactor: separate event
c6a6c06
@nenikitov
refactor: remove flags from pattern, replace by option
7baf735
@nenikitov
refactor: remove unecessary option of pattern and replace by empty pa…
539f75e 
…ttern
@nenikitov
feat: make samples loop properly
2e41b88
@nenikitov
wip: make event pitch
7dd40a9
@nenikitov
fix: proper bpm and note pitch
b6adcc3
@nenikitov
refactor: move all note adding and frequency ratio computations into …
3649f23 
…a separate finetune struct
@nenikitov
feat: make audio stretching linearly interpolate
441ec03
@nenikitov
fix: clicks with linear interpolation
70da45d
@nenikitov
fix: overflow problems
b06854e
@nenikitov
feat: make audio samples resampled to 48khz
b395bf1
@nenikitov
refactor: remove unecessary parameter
d4ee7b2
@nenikitov
fix: remove interpolation for now
def4072
@nenikitov
fix: volume of the instrument
edc4a86
@nenikitov
format
b34c4fa
@nenikitov
wip: remove interpolation and upsampling
ccacd95
@nenikitov
wip: experimenting with linear interpolation
a768669
@nenikitov
feat: made a more faithful frequency calculator
5ff29bb
@nenikitov
sync: main
2c3362a
@nenikitov nenikitov marked this pull request as ready for review October 9, 2024 05:28
UserIsntAvailable
UserIsntAvailable requested changes Oct 10, 2024
View reviewed changes
Copy link
Collaborator

@UserIsntAvailable UserIsntAvailable left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I might have missed something (way too many files to check), overall looks good.

engine/src/asset/sound/dat/finetune.rs Outdated Show resolved Hide resolved
engine/src/asset/sound/dat/mixer.rs Outdated Show resolved Hide resolved
engine/src/asset/sound/dat/t_instrument.rs Outdated Show resolved Hide resolved
engine/src/asset/sound/dat/mixer.rs Outdated Show resolved Hide resolved
engine/src/asset/sound/dat/mixer.rs Outdated Show resolved Hide resolved
engine/src/asset/sound/sample.rs Outdated Show resolved Hide resolved
engine/src/asset/sound/dat/mixer.rs Outdated Show resolved Hide resolved
engine/src/asset/sound/dat/mixer.rs Outdated Show resolved Hide resolved
engine/src/asset/sound/dat/mixer.rs Outdated Show resolved Hide resolved
engine/src/asset/sound/dat/mixer.rs Outdated Show resolved Hide resolved
UserIsntAvailable
UserIsntAvailable approved these changes Oct 12, 2024
View reviewed changes
Copy link
Collaborator

@UserIsntAvailable UserIsntAvailable left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good; there is 1 place where you left a 0., but I can change it myself and just merge this :) 🎉 🌮

@UserIsntAvailable UserIsntAvailable merged commit ff95a5b into main Oct 12, 2024
12 checks passed
@UserIsntAvailable UserIsntAvailable deleted the feat/better-mixer branch October 12, 2024 01:42
@UserIsntAvailable UserIsntAvailable mentioned this pull request Oct 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@UserIsntAvailable UserIsntAvailable UserIsntAvailable approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nenikitov @UserIsntAvailable