Add NFT templete and UT #268
Conversation
| public static event Action<byte[], byte[], BigInteger, byte[]> Transferred; //(byte[] from , byte[] to, BigInteger amount, byte[] TokenId) | ||
|
|
||
| //super admin address | ||
| private static readonly byte[] superAdmin = Helper.ToScriptHash("Nj9Epc1x2sDmd6yH5qJPYwXRqSRf5X6KHE"); |
There was a problem hiding this comment.
Is there possibility to change superAdmin?
There was a problem hiding this comment.
I think it's better not to change it.
|
@vncoelho Thanks. and there are some UTs need to modify neo. |
Co-authored-by: Shargon <shargon@gmail.com>
| private static byte[] StoragePrefixTotalBalance(byte[] owner) => new byte[] { 0x11 }.Concat(owner); | ||
| private static byte[] StoragePrefixTokenBalance(byte[] owner) => new byte[] { 0x12 }.Concat(owner); | ||
| private static byte[] StoragePrefixProperties(byte[] tokenId) => new byte[] { 0x13 }.Concat(tokenId); | ||
| private static byte[] StoragePrefixTokensOf(byte[] owner) => new byte[] { 0x14 }.Concat(owner); |
There was a problem hiding this comment.
Maybe we only need 2 tables to represent the ownership relationship
<tokenId+owner,balance>
<owner+tokenId,balance>
This saves storage space
| private const byte Prefix_TokenOwner = 11; | ||
| private const byte Prefix_TokenBalance = 12; | ||
| private const byte Prefix_Properties = 13; | ||
| private const byte Prefix_TokensOf = 14; |
There was a problem hiding this comment.
I think it's quite dangerous to keep using "byte" as prefix marker... it's much better to use "sbyte" instead. I mean, this code may suddently break if some unexpected user decides to put values over 127... and then this guy just gets multiple bytes (two) instead of one (which is quite unexpected usually), may break some alignment in their backends, or even in the smart contract (which is far worse), I don't know. Better incentive better practices, I think. People will certainly learn from this contract example. Do you agree @erikzhang ?
|
This should be moved to https://github.com/neo-project/examples. |
close #239
and copy the demo to neo-project/examples#30