Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to pass driver instead of database_url #744

Merged
merged 17 commits into from
Oct 31, 2023

Conversation

mariusconjeaud
Copy link
Collaborator

@mariusconjeaud mariusconjeaud commented Aug 29, 2023

Work in progress.

config.py accepts a neo4j driver instead of a DATABASE_URL variable.

Adds close_connection method to db.

Adds a DATABASE_NAME config option, available for both URL and driver init methods

Fixes tests.

@mariusconjeaud mariusconjeaud marked this pull request as draft August 29, 2023 13:56
@codecov
Copy link

codecov bot commented Sep 5, 2023

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (970dae6) 88.74% compared to head (b679c52) 86.34%.

❗ Current head b679c52 differs from pull request most recent head 4b7335f. Consider uploading reports for the commit 4b7335f to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##           rc/5.2.0     #744      +/-   ##
============================================
- Coverage     88.74%   86.34%   -2.40%     
============================================
  Files            22       19       -3     
  Lines          2629     2416     -213     
============================================
- Hits           2333     2086     -247     
- Misses          296      330      +34     
Files Coverage Δ
neomodel/_version.py 100.00% <100.00%> (ø)
neomodel/config.py 100.00% <ø> (ø)
neomodel/util.py 91.55% <96.66%> (+0.26%) ⬆️
neomodel/scripts/neomodel_install_labels.py 0.00% <0.00%> (-85.72%) ⬇️
neomodel/scripts/neomodel_remove_labels.py 0.00% <0.00%> (-88.89%) ⬇️

... and 6 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mariusconjeaud mariusconjeaud marked this pull request as ready for review September 6, 2023 12:44
@mariusconjeaud mariusconjeaud marked this pull request as draft September 6, 2023 12:44
@mariusconjeaud mariusconjeaud marked this pull request as ready for review September 6, 2023 13:47
@sonarcloud
Copy link

sonarcloud bot commented Sep 18, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@mariusconjeaud mariusconjeaud changed the title Add option to pass driver instead of database_url - WIP Add option to pass driver instead of database_url Oct 25, 2023
Copy link

sonarcloud bot commented Oct 31, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@mariusconjeaud mariusconjeaud merged commit 5750747 into rc/5.2.0 Oct 31, 2023
27 checks passed
@mariusconjeaud mariusconjeaud deleted the task/self-managed-driver branch October 31, 2023 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant