Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rc/5.1.2 #749

Merged
merged 19 commits into from
Oct 4, 2023
Merged

Rc/5.1.2 #749

merged 19 commits into from
Oct 4, 2023

Conversation

mariusconjeaud
Copy link
Collaborator

@mariusconjeaud mariusconjeaud commented Sep 22, 2023

Changelog :

Marius Conjeaud and others added 2 commits September 15, 2023 15:40
@codecov
Copy link

codecov bot commented Sep 22, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (90b7a5d) 86.17% compared to head (8c6b874) 86.46%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #749      +/-   ##
==========================================
+ Coverage   86.17%   86.46%   +0.28%     
==========================================
  Files          19       19              
  Lines        2395     2431      +36     
==========================================
+ Hits         2064     2102      +38     
+ Misses        331      329       -2     
Files Coverage Δ
neomodel/_version.py 100.00% <100.00%> (ø)
neomodel/match.py 91.44% <100.00%> (+0.39%) ⬆️
neomodel/relationship.py 97.43% <100.00%> (+0.21%) ⬆️
neomodel/util.py 90.94% <100.00%> (+0.39%) ⬆️
neomodel/core.py 95.15% <94.44%> (+0.26%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mariusconjeaud mariusconjeaud marked this pull request as ready for review September 26, 2023 14:45
neomodel/match.py Outdated Show resolved Hide resolved
neomodel/match.py Outdated Show resolved Hide resolved
neomodel/util.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@owinogradow owinogradow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with small suggestions

@sonarcloud
Copy link

sonarcloud bot commented Oct 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@mariusconjeaud mariusconjeaud merged commit fb3ad1a into master Oct 4, 2023
56 checks passed
@mariusconjeaud mariusconjeaud deleted the rc/5.1.2 branch October 4, 2023 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants