Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

code-cleanup: static methods, @override #407

Merged
merged 2 commits into from
May 30, 2024
Merged

code-cleanup: static methods, @override #407

merged 2 commits into from
May 30, 2024

Conversation

Andy2003
Copy link
Collaborator

@Andy2003 Andy2003 commented May 30, 2024 •
edited
Loading

  • make methods static if possible
  • add missing @override
  • unwrap else after return

@github-actions GitHub Actions
Copy link

github-actions bot commented May 30, 2024 •
edited
Loading

Test Results

290 tests  ±0   290 ✅ ±0   9m 48s ⏱️ +12s
 32 suites ±0     0 💤 ±0 
 32 files   ±0     0 ❌ ±0 

Results for commit b919fbd. ± Comparison against base commit 93adcb7.

♻️ This comment has been updated with latest results.

@Andy2003 Andy2003 changed the title code-cleanup: make methods static if possible code-cleanup: static methods, @override May 30, 2024
@Andy2003 Andy2003 merged commit 99b4198 into master May 30, 2024
2 checks passed
@Andy2003 Andy2003 deleted the feature/static-methods-refactoring branch May 30, 2024 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
refactoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Andy2003