feat: Allow direct rendering of Visitable objects.
#554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes the `org.neo4j.cypherdsl.core.renderer.Renderer#render` method to accept any `Visitable` so that an intermediate representation can be retrieved. Reluctant use is suggested, as the intermediate representation won't be cached in the renderer. In addition, an overload of `toString` has been added to many `Visitable` types. While I would liked to have added this to the `Visitable` interface as suggested by @lukaseder, this is not possible as specified in the JLS 9.4.1.2. "Requirements in Overriding" (https://docs.oracle.com/javase/specs/jls/se17/html/jls-9.html#jls-9.4.1.2) (more background here https://mail.openjdk.org/pipermail/lambda-dev/2013-March/008435.html) Closes #552.
I assumed there was some base class for all |
… to correctly quote the error message and commit everything.
|
Note, you can still re-declare the method (keeping it
|
|
Oh that's a good hint, thank you! |
|
Re abstract base clase: Yes, a major refactoring of the general structure is due, see #550. This project grew quite a bit since it's inception as an internal Spring Data module. |
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the
org.neo4j.cypherdsl.core.renderer.Renderer#rendermethod to accept anyVisitableso that an intermediate representation can be retrieved.Reluctant use is suggested, as the intermediate representation won't be cached in the renderer.
In addition, an overload of
toStringhas been added to manyVisitabletypes. While I would liked to have added this to theVisitableinterface as suggested by @lukaseder, this is not possible as specified in the JLS 9.4.1.2. "Requirements in Overriding" (https://docs.oracle.com/javase/specs/jls/se17/html/jls-9.html#jls-9.4.1.2) (more background here https://mail.openjdk.org/pipermail/lambda-dev/2013-March/008435.html)Closes #552.