Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recommend 5.23+ users to disable jmx #247

Merged
merged 5 commits into from
Nov 11, 2024
Merged

Recommend 5.23+ users to disable jmx #247

merged 5 commits into from
Nov 11, 2024

Conversation

SeBBBe
Copy link
Collaborator

@SeBBBe SeBBBe commented Oct 29, 2024

With the latest commit, JMX is no longer mandatory as long as discovery service v2 is enabled. As Neo4j discourages the use of JMX, update our documentation to be in line with this recommendation. Not sure which version this change will land in.


If you open a PR that needs to go into a current version, you need to cherry-pick your commit from dev over to the current version branch. Only then will the proper builds that generate html/pdf be run. But beware: Docs will be generated but not published automatically!

  • N/A - or - I have added the appropriate "cherry-pick-to" labels to this PR so I don't forget to do this later!

@SeBBBe SeBBBe requested a review from SaschaPeukert October 29, 2024 10:15
@SeBBBe SeBBBe marked this pull request as ready for review October 29, 2024 11:37
@SeBBBe SeBBBe requested a review from eve-bright November 5, 2024 09:57
@SeBBBe SeBBBe requested a review from alexnb November 11, 2024 07:07
Copy link
Collaborator

@alexnb alexnb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, suggesting "every sentence on new line" and using "JMX metrics" to be more precise.

modules/ROOT/pages/addition/instance-requirements.adoc Outdated Show resolved Hide resolved
modules/ROOT/pages/addition/instance-requirements.adoc Outdated Show resolved Hide resolved
SeBBBe and others added 2 commits November 11, 2024 14:09
Co-authored-by: Alexander Bouriakov <alexander.bouriakov@neo4j.com>
Co-authored-by: Alexander Bouriakov <alexander.bouriakov@neo4j.com>
@neo-technology-commit-status-publisher
Copy link
Collaborator

Thanks for the documentation updates.

The preview documentation has now been torn down - reopening this PR will republish it.

@SeBBBe SeBBBe merged commit 93c412e into neo4j:dev Nov 11, 2024
4 checks passed
@SeBBBe SeBBBe deleted the jmx-optional branch November 11, 2024 13:29
SeBBBe added a commit to SeBBBe/docs-ops-manager that referenced this pull request Nov 11, 2024
* Recommend 5.23+ users to disable jmx

* Add jwt timeout to server reference

* Revert "Add jwt timeout to server reference"

This reverts commit 268834f.

* Update modules/ROOT/pages/addition/instance-requirements.adoc

Co-authored-by: Alexander Bouriakov <alexander.bouriakov@neo4j.com>

* Update modules/ROOT/pages/addition/instance-requirements.adoc

Co-authored-by: Alexander Bouriakov <alexander.bouriakov@neo4j.com>

---------

Co-authored-by: Alexander Bouriakov <alexander.bouriakov@neo4j.com>
SeBBBe added a commit that referenced this pull request Nov 11, 2024
* Recommend 5.23+ users to disable jmx

* Add jwt timeout to server reference

* Revert "Add jwt timeout to server reference"

This reverts commit 268834f.

* Update modules/ROOT/pages/addition/instance-requirements.adoc



* Update modules/ROOT/pages/addition/instance-requirements.adoc



---------

Co-authored-by: Alexander Bouriakov <alexander.bouriakov@neo4j.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants