-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Recommend 5.23+ users to disable jmx #247
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 268834f.
alexnb
approved these changes
Nov 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, suggesting "every sentence on new line" and using "JMX metrics" to be more precise.
Co-authored-by: Alexander Bouriakov <alexander.bouriakov@neo4j.com>
Co-authored-by: Alexander Bouriakov <alexander.bouriakov@neo4j.com>
Collaborator
Thanks for the documentation updates. The preview documentation has now been torn down - reopening this PR will republish it. |
SeBBBe
added a commit
to SeBBBe/docs-ops-manager
that referenced
this pull request
Nov 11, 2024
* Recommend 5.23+ users to disable jmx * Add jwt timeout to server reference * Revert "Add jwt timeout to server reference" This reverts commit 268834f. * Update modules/ROOT/pages/addition/instance-requirements.adoc Co-authored-by: Alexander Bouriakov <alexander.bouriakov@neo4j.com> * Update modules/ROOT/pages/addition/instance-requirements.adoc Co-authored-by: Alexander Bouriakov <alexander.bouriakov@neo4j.com> --------- Co-authored-by: Alexander Bouriakov <alexander.bouriakov@neo4j.com>
SeBBBe
added a commit
that referenced
this pull request
Nov 11, 2024
* Recommend 5.23+ users to disable jmx * Add jwt timeout to server reference * Revert "Add jwt timeout to server reference" This reverts commit 268834f. * Update modules/ROOT/pages/addition/instance-requirements.adoc * Update modules/ROOT/pages/addition/instance-requirements.adoc --------- Co-authored-by: Alexander Bouriakov <alexander.bouriakov@neo4j.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the latest commit, JMX is no longer mandatory as long as discovery service v2 is enabled. As Neo4j discourages the use of JMX, update our documentation to be in line with this recommendation. Not sure which version this change will land in.
If you open a PR that needs to go into a current version, you need to cherry-pick your commit from dev over to the current version branch. Only then will the proper builds that generate html/pdf be run. But beware: Docs will be generated but not published automatically!