Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure credentials are not left in form after disconnect #1968

Merged
merged 1 commit into from
May 23, 2024
Merged

Ensure credentials are not left in form after disconnect #1968

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions src/shared/modules/connections/connectionsDuck.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,7 +193,7 @@ export function getConnectionData(
return { ...data, username: memoryUsername, password: memoryPassword }
}

return data
return { ...data, username: data.username ? data.username : memoryUsername }
nnecla marked this conversation as resolved.
Show resolved Hide resolved
}

const removeConnectionHelper = (
Expand Down Expand Up @@ -652,9 +652,10 @@ export const disconnectEpic = (action$: any, store: any) => {
.merge(action$.ofType(USER_CLEAR))
.do(() => bolt.closeConnection())
.do(() => store.dispatch(resetUseDb()))
.do((action: any) =>
.do((action: any) => {
memoryPassword = ''
store.dispatch(updateConnection({ id: action.id, password: '' }))
)
})
.map(() => setActiveConnection(null))
}
export const silentDisconnectEpic = (action$: any, store: any) => {
Expand Down
Loading