Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding information about expanding the query area #1976

Merged
merged 6 commits into from
Sep 16, 2024

Conversation

lidiazuin
Copy link
Contributor

@lidiazuin lidiazuin commented Sep 11, 2024

As requested in user feedback.

https://trello.com/c/GOM8inXz/

Copy link
Contributor

@AlexicaWright AlexicaWright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure if we can substitute all "click" for "select" here, they are not really synonyms. Let's think about the wider implications of this change, we would have to change it everywhere. I agree that in many cases you probably could use "select", but far from all. I try to use to avoid teaching users how to click a button. But in some cases, it's necessary to say that instead of select.

@lidiazuin
Copy link
Contributor Author

I reverted the changes in "to click" so we can do only the requested update and discuss what we are going to do about that.

Copy link
Contributor

@AlexicaWright AlexicaWright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some ideas!

docs/modules/ROOT/pages/operations/result-frames.adoc Outdated Show resolved Hide resolved
* Click a node to get a halo, where you can:
** Dismiss/hide a node by clicking the image:dismiss-node.png[width=3%] icon.
* Select a node to get a halo, where you can:
** Dismiss/hide a node by selecting the image:dismiss-node.png[width=3%] icon.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
** Dismiss/hide a node by selecting the image:dismiss-node.png[width=3%] icon.
** Dismiss/hide a node with the image:dismiss-node.png[width=3%] icon.

** Expand/collapse child relationships by clicking the icon image:expand-collapse.png[width=3%] icon.
Alternatively, you can double-click a node.
** Unlock the node to re-layout it by clicking the image:unlock-relayout.png[width=3%] icon.
Alternatively, you can click the node and drag it around.
Alternatively, you can select the node and drag it around.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Alternatively, you can select the node and drag it around.
Alternatively, you can select and hold the node to drag it around.

* Click a node to get a halo, where you can:
** Dismiss/hide a node by clicking the image:dismiss-node.png[width=3%] icon.
* Select a node to get a halo, where you can:
** Dismiss/hide a node by selecting the image:dismiss-node.png[width=3%] icon.
** Expand/collapse child relationships by clicking the icon image:expand-collapse.png[width=3%] icon.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
** Expand/collapse child relationships by clicking the icon image:expand-collapse.png[width=3%] icon.
** Expand/collapse child relationships with the icon image:expand-collapse.png[width=3%] icon.

* If you cannot see the whole graph or the results display too close together, you can adjust by moving the visual view and dragging nodes to rearrange them.
* To move the view to see more parts of the graph, click an empty spot within the graph pane and drag it.
* To move the view to see more parts of the graph, select an empty spot within the graph pane and drag it.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* To move the view to see more parts of the graph, select an empty spot within the graph pane and drag it.
* To move the view to see more parts of the graph, use an empty spot within the graph pane and drag it.

@lidiazuin
Copy link
Contributor Author

Great ideas! I added some manually as they weren't syncing in the PR.

Copy link
Contributor

@AlexicaWright AlexicaWright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few more suggestions.

docs/modules/ROOT/pages/operations/result-frames.adoc Outdated Show resolved Hide resolved
docs/modules/ROOT/pages/operations/result-frames.adoc Outdated Show resolved Hide resolved
Co-authored-by: Jessica Wright <49636617+AlexicaWright@users.noreply.github.com>
Co-authored-by: Jessica Wright <49636617+AlexicaWright@users.noreply.github.com>
Copy link
Contributor

@AlexicaWright AlexicaWright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was borderline Pandora's box! Looks good now! Thanks @lidiazuin

docs/modules/ROOT/pages/operations/result-frames.adoc Outdated Show resolved Hide resolved
docs/modules/ROOT/pages/operations/result-frames.adoc Outdated Show resolved Hide resolved
@lidiazuin lidiazuin merged commit 2af7843 into neo4j:master Sep 16, 2024
15 of 16 checks passed
@lidiazuin lidiazuin deleted the docs-resultframes branch September 16, 2024 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants