JS driver v1.4.0-rc1: Checking in transpiled files for bower

neo4j · Jun 29, 2017 · 20653c5 · 20653c5
1 parent 4d628f5
commit 20653c5
Show file tree

Hide file tree

Showing 6 changed files with 77 additions and 48 deletions.
diff --git a/lib/browser/neo4j-web.js b/lib/browser/neo4j-web.js
@@ -27919,6 +27919,7 @@ var Neo4jError = function (_Error) {
 
     _this.message = message;
     _this.code = code;
+    _this.name = "Neo4jError";
     return _this;
   }
 
@@ -31351,7 +31352,7 @@ var ConnectionHolder = function () {
 
     /**
      * Notify this holder that single party does not require current connection any more.
-     * @return {Promise<Connection>} promise resolved with the current connection.
+     * @return {Promise<Connection>} promise resolved with the current connection, never a rejected promise.
      */
 
   }, {
@@ -35430,10 +35431,6 @@ var _connectionHolder = require('./internal/connection-holder');
 
 function _interopRequireDefault(obj) { return obj && obj.__esModule ? obj : { default: obj }; }
 
-/**
-  * A stream of {@link Record} representing the result of a statement.
-  * @access public
-  */
 /**
  * Copyright (c) 2002-2017 "Neo Technology,","
  * Network Engine for Objects in Lund AB [http://neotechnology.com]
@@ -35453,6 +35450,16 @@ function _interopRequireDefault(obj) { return obj && obj.__esModule ? obj : { de
  * limitations under the License.
  */
 
+var DEFAULT_ON_ERROR = function DEFAULT_ON_ERROR(error) {
+  console.log('Uncaught error when processing result: ' + error);
+};
+var DEFAULT_ON_COMPLETED = function DEFAULT_ON_COMPLETED(summary) {};
+
+/**
+  * A stream of {@link Record} representing the result of a statement.
+  * @access public
+  */
+
 var Result = function () {
   /**
    * Inject the observer to be used.
@@ -35554,10 +35561,10 @@ var Result = function () {
     value: function subscribe(observer) {
       var _this = this;
 
-      var onCompletedOriginal = observer.onCompleted;
       var self = this;
-      var onCompletedWrapper = function onCompletedWrapper(metadata) {
 
+      var onCompletedOriginal = observer.onCompleted || DEFAULT_ON_COMPLETED;
+      var onCompletedWrapper = function onCompletedWrapper(metadata) {
         var additionalMeta = self._metaSupplier();
         for (var key in additionalMeta) {
           if (additionalMeta.hasOwnProperty(key)) {
@@ -35574,10 +35581,7 @@ var Result = function () {
       };
       observer.onCompleted = onCompletedWrapper;
 
-      var onErrorOriginal = observer.onError || function (error) {
-        console.log("Uncaught error when processing result: " + error);
-      };
-
+      var onErrorOriginal = observer.onError || DEFAULT_ON_ERROR;
       var onErrorWrapper = function onErrorWrapper(error) {
         // notify connection holder that the used connection is not needed any more because error happened
         // and result can't bee consumed any further; call the original onError callback after that

diff --git a/lib/browser/neo4j-web.min.js b/lib/browser/neo4j-web.min.js
diff --git a/lib/browser/neo4j-web.test.js b/lib/browser/neo4j-web.test.js
diff --git a/lib/v1/error.js b/lib/v1/error.js
@@ -77,6 +77,7 @@ var Neo4jError = function (_Error) {
 
     _this.message = message;
     _this.code = code;
+    _this.name = "Neo4jError";
     return _this;
   }
 

diff --git a/lib/v1/internal/connection-holder.js b/lib/v1/internal/connection-holder.js
@@ -84,7 +84,7 @@ var ConnectionHolder = function () {
 
     /**
      * Notify this holder that single party does not require current connection any more.
-     * @return {Promise<Connection>} promise resolved with the current connection.
+     * @return {Promise<Connection>} promise resolved with the current connection, never a rejected promise.
      */
 
   }, {

diff --git a/lib/v1/result.js b/lib/v1/result.js
@@ -24,10 +24,6 @@ var _connectionHolder = require('./internal/connection-holder');
 
 function _interopRequireDefault(obj) { return obj && obj.__esModule ? obj : { default: obj }; }
 
-/**
-  * A stream of {@link Record} representing the result of a statement.
-  * @access public
-  */
 /**
  * Copyright (c) 2002-2017 "Neo Technology,","
  * Network Engine for Objects in Lund AB [http://neotechnology.com]
@@ -47,6 +43,16 @@ function _interopRequireDefault(obj) { return obj && obj.__esModule ? obj : { de
  * limitations under the License.
  */
 
+var DEFAULT_ON_ERROR = function DEFAULT_ON_ERROR(error) {
+  console.log('Uncaught error when processing result: ' + error);
+};
+var DEFAULT_ON_COMPLETED = function DEFAULT_ON_COMPLETED(summary) {};
+
+/**
+  * A stream of {@link Record} representing the result of a statement.
+  * @access public
+  */
+
 var Result = function () {
   /**
    * Inject the observer to be used.
@@ -148,10 +154,10 @@ var Result = function () {
     value: function subscribe(observer) {
       var _this = this;
 
-      var onCompletedOriginal = observer.onCompleted;
       var self = this;
-      var onCompletedWrapper = function onCompletedWrapper(metadata) {
 
+      var onCompletedOriginal = observer.onCompleted || DEFAULT_ON_COMPLETED;
+      var onCompletedWrapper = function onCompletedWrapper(metadata) {
         var additionalMeta = self._metaSupplier();
         for (var key in additionalMeta) {
           if (additionalMeta.hasOwnProperty(key)) {
@@ -168,10 +174,7 @@ var Result = function () {
       };
       observer.onCompleted = onCompletedWrapper;
 
-      var onErrorOriginal = observer.onError || function (error) {
-        console.log("Uncaught error when processing result: " + error);
-      };
-
+      var onErrorOriginal = observer.onError || DEFAULT_ON_ERROR;
       var onErrorWrapper = function onErrorWrapper(error) {
         // notify connection holder that the used connection is not needed any more because error happened
         // and result can't bee consumed any further; call the original onError callback after that
-Original file line number
+Diff line change
@@ Expand Up / @@ -84,7 +84,7 @@ var ConnectionHolder = function () { @@
         /**
          * Notify this holder that single party does not require current connection any more.
-         * @return {Promise<Connection>} promise resolved with the current connection.
+         * @return {Promise<Connection>} promise resolved with the current connection, never a rejected promise.
          */
       }, {
@@ Expand Down @@