-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simple non-antlr AT parser #6
Conversation
I feel that we should keep the ANTLR grammars around, though not in |
That's not a bad suggestion; added them in a |
Last commit published: 7d332a6e0ed61b5edfe597f2050f0176b3cade59. PR PublishingThe artifacts published by this PR:
Repository DeclarationIn order to use the artifacts published by the PR, add the following repository to your buildscript: repositories {
maven {
name 'Maven for PR #6' // https://github.com/neoforged/AccessTransformers/pull/6
url 'https://prmaven.neoforged.net/AccessTransformers/pr6'
content {
includeModule('net.neoforged', 'accesstransformers')
includeModule('net.neoforged.accesstransformers', 'at-cli')
includeModule('net.neoforged.accesstransformers', 'at-modlauncher')
includeModule('net.neoforged.accesstransformers', 'at-parser')
}
}
} |
Antlr, unfortunately, is Not Great. At this point, it's beginning to consistently be badly-supported by gradle and IDEs alike; furthermore, it's not necessary at all for this use case. AT files are quite easy to parse; here, I implement a small, regex-free AT file parser that as far as I can tell is consistent with the old behavior of AT files. While it seems to run correctly on all the tests, if anyone finds an issue with my implementation, please let me know.