Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve the error message when there are no Git tags #13

Merged
merged 1 commit into from
Dec 15, 2023
Merged

Improve the error message when there are no Git tags #13

merged 1 commit into from
Dec 15, 2023

Conversation

shartte
Copy link
Contributor

@shartte shartte commented Nov 26, 2023

Previous error message:

Caused by: java.lang.NullPointerException: Cannot invoke "java.util.List.size()" because "self" is null

New error message:

Caused by: org.gradle.api.GradleException: Cannot calculate the project version without a previous Git tag. Did you forget to run "git fetch --tags"?

@Technici4n
Copy link
Member

Note that you have a merge conflict.

@Technici4n Technici4n linked an issue Nov 26, 2023 that may be closed by this pull request
GradleUtils doesn't handle no available tags gracefully #10
Closed
@shartte
Copy link
Contributor Author

shartte commented Nov 26, 2023

Huh my fork was outdated and I didn't notice

@shartte
Copy link
Contributor Author

shartte commented Nov 26, 2023

Fixed

@Matyrobbrt Matyrobbrt added bug Something isn't working enhancement New feature or request labels Dec 15, 2023
@Matyrobbrt Matyrobbrt merged commit 89928ba into neoforged:main Dec 15, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

GradleUtils doesn't handle no available tags gracefully
3 participants
@shartte @Technici4n @Matyrobbrt