Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Provide the latest nix flake lock #602

Merged
merged 2 commits into from
Sep 6, 2024

Conversation

jfvillablanca
Copy link
Collaborator

@jfvillablanca jfvillablanca commented Sep 4, 2024

What does this PR do?

  • This updates the nixpkgs input in the nix flake in order to bump the rustc version from 1.72.0 to 1.80.1 if websurfx is packaged via nix build
  • nodePackages_latest.eslint is changed to eslint since it's been moved as a top-level package in upstream NixOS/nixpkgs repo

Why is this change important?

  • This enables building websurfx in a reproducible manner via nix

How to test this PR locally?

  • Run nix build .#default
  • Run the build result in ./result/bin/websurfx

Related issues

Closes #580

jfvillablanca and others added 2 commits September 5, 2024 07:14
- this updates rustc to 1.80.1
- `eslint` has been moved as a top-level package in upstream NixOS/nixpkgs
  Context: package maintainers are slowly de-bloating
  `node-packages.nix`
@neon-mmd neon-mmd changed the title 🐛 fix: update nix flake lock 🐛 Provide the latest nix flake lock Sep 5, 2024
Copy link
Owner

@neon-mmd neon-mmd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks ❤️ for working on this PR. We really appreciate it. Good job!! Keep it up!! 👍 Since everything looks good. We will merge this PR as soon as possible. 🙂

@neon-mmd neon-mmd merged commit 9984ba0 into neon-mmd:rolling Sep 6, 2024
4 checks passed
@jfvillablanca jfvillablanca deleted the FIX/580_nix-build-fails branch September 7, 2024 00:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 Nix build fails
2 participants