Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(pageserver): make image layer creation atomic #9584

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

skyzh
Copy link
Member

@skyzh skyzh commented Oct 30, 2024

Problem

If image layer creation failed in the middle, it will leave some temporary files on the disk. Part of #8362, also need to fix L0 compaction path in the future.

Summary of changes

Use the newly-added batch layer writer to ensure either all of them are created successfully or none of them are created successfully.

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • Do we need to implement analytics? if so did you add the relevant metrics to the dashboard?
  • If this PR requires public announcement, mark it with /release-notes label and add several sentences in this section.

Checklist before merging

  • Do not forget to reformat commit message to not include the above checklist

Copy link

github-actions bot commented Oct 30, 2024

5328 tests run: 5106 passed, 0 failed, 222 skipped (full report)


Flaky tests (1)

Postgres 17

Code coverage* (full report)

  • functions: 31.5% (7778 of 24698 functions)
  • lines: 49.0% (61045 of 124704 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
8ee5588 at 2024-10-31T17:37:55.027Z :recycle:

Signed-off-by: Alex Chi Z <chi@neon.tech>
@skyzh skyzh requested a review from arpad-m October 31, 2024 16:42
@skyzh skyzh marked this pull request as ready for review October 31, 2024 16:42
@skyzh skyzh requested a review from a team as a code owner October 31, 2024 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant