-
Notifications
You must be signed in to change notification settings - Fork 437
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add dependabot #9585
base: main
Are you sure you want to change the base?
Add dependabot #9585
Conversation
Our dependencies don't necessarily receive updates unless people run into issues. This should help keep our dependencies in check a little bit better. Signed-off-by: Tristan Partin <tristan@neon.tech>
e60b4b4
to
3dd61ed
Compare
rebase-strategy: auto | ||
|
||
- directory: / | ||
package-ecosystem: docker |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have no clue if this will catch build-tools.Dockerfile and compute-node.Dockerfile
5328 tests run: 5106 passed, 0 failed, 222 skipped (full report)Code coverage* (full report)
* collected from Rust tests only The comment gets automatically updated with the latest test results
3dd61ed at 2024-10-31T01:43:34.720Z :recycle: |
package-ecosystem: cargo | ||
schedule: | ||
interval: daily | ||
rebase-strategy: auto |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd actually do
rebase-strategy: auto | |
rebase-strategy: disabled |
Everywhere, because otherwise everytime main
changes you get a crazy amount of Github Actions triggered and that'll be quite expensive. Folks can easily do @dependabot rebase
manually when needed?
interval: daily | ||
rebase-strategy: auto | ||
|
||
- directory: test_runner/pg_clients/csharp/npgsql |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You could use the directories
key to make this less verbose I think? See e.g. https://github.com/neondatabase/infra/blob/main/.github/dependabot.yml for an example?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would be nice to group the individual updates into a combined commit to reduce the spam of both PRs and commits that end up later in the log.
- directory: / | ||
package-ecosystem: cargo | ||
schedule: | ||
interval: daily |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think daily interval is too often, weekly would be better.
Our dependencies don't necessarily receive updates unless people run into issues. This should help keep our dependencies in check a little bit better.