Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dependabot #9585

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add dependabot #9585

wants to merge 1 commit into from

Conversation

tristan957
Copy link
Member

Our dependencies don't necessarily receive updates unless people run into issues. This should help keep our dependencies in check a little bit better.

@tristan957 tristan957 requested a review from a team October 31, 2024 00:44
@tristan957
Copy link
Member Author

Our dependencies don't necessarily receive updates unless people run
into issues. This should help keep our dependencies in check a little
bit better.

Signed-off-by: Tristan Partin <tristan@neon.tech>
rebase-strategy: auto

- directory: /
package-ecosystem: docker
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no clue if this will catch build-tools.Dockerfile and compute-node.Dockerfile

Copy link

5328 tests run: 5106 passed, 0 failed, 222 skipped (full report)


Code coverage* (full report)

  • functions: 31.5% (7768 of 24686 functions)
  • lines: 49.0% (61002 of 124616 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
3dd61ed at 2024-10-31T01:43:34.720Z :recycle:

package-ecosystem: cargo
schedule:
interval: daily
rebase-strategy: auto

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd actually do

Suggested change
rebase-strategy: auto
rebase-strategy: disabled

Everywhere, because otherwise everytime main changes you get a crazy amount of Github Actions triggered and that'll be quite expensive. Folks can easily do @dependabot rebase manually when needed?

interval: daily
rebase-strategy: auto

- directory: test_runner/pg_clients/csharp/npgsql

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could use the directories key to make this less verbose I think? See e.g. https://github.com/neondatabase/infra/blob/main/.github/dependabot.yml for an example?

Copy link
Member

@arpad-m arpad-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be nice to group the individual updates into a combined commit to reduce the spam of both PRs and commits that end up later in the log.

- directory: /
package-ecosystem: cargo
schedule:
interval: daily
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think daily interval is too often, weekly would be better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants