-
Notifications
You must be signed in to change notification settings - Fork 437
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wal_decoder: add rate limited log for unexpected rm ids #9592
Draft
VladLazar
wants to merge
3
commits into
main
Choose a base branch
from
vlad/log-on-unexpected-pg-record
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem We would like to handle the tightening of unexpected WAL record types, but don't know if this happens in the field. Summary of Changes Add a rate-limited WAL log on such events. The rate limiting is to play it safe and guard against spewing in prod.
VladLazar
changed the title
wal_decoder: add rate limited log for unexpecte rm ids
wal_decoder: add rate limited log for unexpected rm ids
Oct 31, 2024
5328 tests run: 4650 passed, 456 failed, 222 skipped (full report)Failures on Postgres 17
Failures on Postgres 16
Failures on Postgres 15
Failures on Postgres 14
Flaky tests (2)Postgres 17
Postgres 14
Test coverage report is not availableThe comment gets automatically updated with the latest test results
fd5aa06 at 2024-10-31T18:08:51.340Z :recycle: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
We would like to handle the tightening of unexpected WAL record types, but don't know if this happens in the field.
Summary of Changes
Add a rate-limited WAL log on such events. The rate limiting is to play it safe and guard against spewing in prod.
Checklist before requesting a review
Checklist before merging