Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[proxy] use the proxy protocol v2 command to silence some logs #9620

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

conradludgate
Copy link
Contributor

@conradludgate conradludgate commented Nov 4, 2024

The PROXY Protocol V2 offers a "command" concept. It can be of two different values. "Local" and "Proxy". The spec suggests that "Local" be used for health-checks. We can thus use this to silence logging for such health checks such as those from NLB.

This additionally refactors the flow to be a bit more type-safe, self documenting and using zerocopy deser.

Copy link

github-actions bot commented Nov 4, 2024

5328 tests run: 5106 passed, 0 failed, 222 skipped (full report)


Flaky tests (1)

Postgres 17

Code coverage* (full report)

  • functions: 31.5% (7797 of 24752 functions)
  • lines: 48.9% (61135 of 124940 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
345f9e7 at 2024-11-04T18:17:29.453Z :recycle:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant