Construct models::TenantConfig only once #9630
Open
+14
−101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since 5f83c92 we've had duplication in construction of models::TenantConfig, where both constructs contained the same code. This PR removes one of the two locations.
arpad-m
force-pushed
the
arpad/tenant_config_merge
branch
from
647308c
to
c63f914
Compare
5328 tests run: 5106 passed, 0 failed, 222 skipped (full report)Code coverage* (full report)
* collected from Rust tests only The comment gets automatically updated with the latest test results
c63f914 at 2024-11-04T20:56:22.224Z :recycle: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since 5f83c92/#1504 we've had duplication in
construction of models::TenantConfig, where both constructs contained
the same code. This PR removes one of the two locations to avoid the duplication.