Skip to content

Commit

Permalink
TASK: Drop runBare() override from StandaloneViewTest
Browse files Browse the repository at this point in the history
As of PHPUnit 11 `runBare()` is a `final` method.

This was written ages ago by Sebastian Kurfürst, who recently said:

> IMHO we wanted to run each test twice to run it without cache and
> then with cache. But it seems this was broken anyways since a long
> time – so we can drop it
  • Loading branch information
kdambekalns committed Nov 19, 2024
1 parent 19ac0ef commit cd75bfb
Showing 1 changed file with 0 additions and 15 deletions.
15 changes: 0 additions & 15 deletions Neos.FluidAdaptor/Tests/Functional/View/StandaloneViewTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -30,21 +30,6 @@ class StandaloneViewTest extends FunctionalTestCase
*/
protected $standaloneViewNonce = '42';

/**
* Every testcase should run *twice*. First, it is run in *uncached* way, second,
* it is run *cached*. To make sure that the first run is always uncached, the
* $standaloneViewNonce is initialized to some random value which is used inside
* an overridden version of StandaloneView::createIdentifierForFile.
*/
public function runBare(): void
{
$this->standaloneViewNonce = uniqid('', true);
parent::runBare();
$numberOfAssertions = $this->getNumAssertions();
parent::runBare();
$this->addToAssertionCount($numberOfAssertions);
}

/**
* @test
*/
Expand Down

0 comments on commit cd75bfb

Please sign in to comment.