Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUGFIX: Streamline exit(1) to web response with HTTP status code 500 #3365

Merged
merged 1 commit into from
Jun 19, 2024

Conversation

christophlehmann
Copy link

@christophlehmann christophlehmann commented Jun 10, 2024

With this critical error messages like the following now sends the HTTP status code 500 instead 200 in order to state something is not okay on the server side:

Flow could not create the directory "/var/www/html/Data/Persistent". Please check the file permissions manually or run "sudo ./flow flow:core:setfilepermissions" to fix the problem. (Error #1347526553)

Resolved: #3364

Checklist

  • Code follows the PSR-2 coding style
  • Tests have been created, run and adjusted as needed
  • The PR is created against the lowest maintained branch
  • Reviewer - PR Title is brief but complete and starts with FEATURE|TASK|BUGFIX
  • Reviewer - The first section explains the change briefly for change-logs
  • Reviewer - Breaking Changes are marked with !!! and have upgrade-instructions

With this critical error messages like the following now sends the HTTP status code 500 instead 200 in order to state something is not okay on the server side.

Flow could not create the directory "/var/www/html/Data/Persistent". Please check the file permissions manually or run "sudo ./flow flow:core:setfilepermissions" to fix the problem. (Error #1347526553)

Resolves: neos#3364
Copy link
Member

@kitsunet kitsunet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a great solution, thanks, this is all early enough to not interfere with anything else.

@kitsunet
Copy link
Member

I would merge this in 24h if no one else has a look here.

@kitsunet
Copy link
Member

This technically belongs into 8.3 unless there are strong reasons for it to go somewhere else, as everythign else is in security fix only mode already. I would do that on merge then.

@kdambekalns kdambekalns changed the base branch from 8.0 to 8.3 June 14, 2024 14:52
@github-actions github-actions bot added 8.3 and removed 8.0 labels Jun 14, 2024
@mhsdesign mhsdesign merged commit 89c51a2 into neos:8.3 Jun 19, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants