TASK: Make NodeAggregateIds countable

neos · Sep 24, 2024 · 7331e40 · 7331e40
1 parent 970f207
commit 7331e40
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/Neos.ContentRepository.Core/Classes/SharedModel/Node/NodeAggregateIds.php b/Neos.ContentRepository.Core/Classes/SharedModel/Node/NodeAggregateIds.php
@@ -14,7 +14,6 @@
 
 namespace Neos\ContentRepository\Core\SharedModel\Node;
 
-use Neos\ContentRepository\Core\Projection\ContentGraph\Node;
 use Neos\ContentRepository\Core\Projection\ContentGraph\Nodes;
 
 /**
@@ -23,7 +22,7 @@
  * @implements \IteratorAggregate<string,NodeAggregateId>
  * @api
  */
-final class NodeAggregateIds implements \IteratorAggregate, \JsonSerializable
+final class NodeAggregateIds implements \IteratorAggregate, \Countable, \JsonSerializable
 {
  /**
  * @var array<string,NodeAggregateId>
@@ -124,4 +123,9 @@ public function map(\Closure $callback): array
  {
  return array_map($callback, $this->nodeAggregateIds);
  }
+
+ public function count(): int
+ {
+ return count($this->nodeAggregateIds);
+ }
 }
diff --git a/Neos.Neos/Classes/Fusion/MenuItemsImplementation.php b/Neos.Neos/Classes/Fusion/MenuItemsImplementation.php
@@ -196,7 +196,7 @@ protected function buildItems(): array
  $maximumLevels = min($maximumLevels, $maxLevelsBasedOnLastLevel);
  } elseif ($lastLevels < 0) {
  $currentNodeAncestorAggregateIds = $this->getCurrentNodeRootlineAggregateIds();
- $depthOfCurrentDocument = count(iterator_to_array($currentNodeAncestorAggregateIds)) - 1;
+ $depthOfCurrentDocument = count($currentNodeAncestorAggregateIds) - 1;
  $maxLevelsBasedOnLastLevel = max($depthOfCurrentDocument + $lastLevels - $depthOfEntryParentNodeAggregateId + 1, 0);
  $maximumLevels = min($maximumLevels, $maxLevelsBasedOnLastLevel);
  }