FEATURE: Speedup content cache flush by using cte in findAncestorNodeAggregateIds
#5261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhsdesign
commented
Sep 24, 2024
...res/ProjectionIntegrityViolationDetection/AllNodesAreConnectedToARootNodePerSubgraph.feature
Outdated
Show resolved
Hide resolved
dlubitz
reviewed
Sep 25, 2024
Neos.ContentGraph.DoctrineDbalAdapter/src/Domain/Repository/ContentGraph.php
Show resolved
Hide resolved
mhsdesign
changed the title
findAncestorNodeAggregateIds
In the case of the content cache flusher we do not care about the order and ordering it by parentnodeanchor and position (for siblings) is slower and not even correct in all situations as the parentnodeanchor is just an autoincrement without meaning.
dlubitz
reviewed
Sep 30, 2024
Comment on lines
198
to
200
| ->innerJoin('n', $this->nodeQueryBuilder->tableNames->hierarchyRelation(), 'ch', 'ch.parentnodeanchor = n.relationanchorpoint') | ||
| ->innerJoin('ch', $this->nodeQueryBuilder->tableNames->node(), 'c', 'c.relationanchorpoint = ch.childnodeanchor') | ||
| ->innerJoin('n', $this->nodeQueryBuilder->tableNames->hierarchyRelation(), 'ph', 'n.relationanchorpoint = ph.childnodeanchor') |
There was a problem hiding this comment.
This query again joins, the hierachy relation twice. I think this is not needed. See: #5268
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup to #5221
ContentGraph::findParentNodeAggregatesbecomes slower on bigger datasets. Due to the mass on executions on acr:replay, this sums up very quickly. Via #5268 the query will be improved but this pr introducesContentGraph::findAncestorNodeAggregateIdsto make this operation as performant as possible.Adds comment for
CacheFlushingStrategystrategiesIntroduces
ContentGraphInterface::findAncestorNodeAggregateIdsusing native sql cte to speedup cache flushing. (see comment)Move test which creates illegal state to content graph package and use native sql to create the state to not run any catchup hooks. Previously we needed to handle the case of infinite loops to not crash:
fixes a bug where you cannot replay because the workspace is "missing" and no content graph exists
Upgrade instructions
Review instructions
Checklist
FEATURE|TASK|BUGFIX!!!and have upgrade-instructions