Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TASK: Remove workspaceTitle, workspaceDescription and workspaceOwner use from behat core tests #5271

Open
wants to merge 1 commit into
base: feature/4726-extract-workspace-metadata-and-user-assignment-to-neos
Choose a base branch
from

Conversation

bwaidelich
Copy link
Member

No description provided.

@mhsdesign mhsdesign force-pushed the feature/4726-extract-workspace-metadata-and-user-assignment-to-neos-wip branch from d42c041 to adce185 Compare October 1, 2024 15:32
Copy link
Member

@mhsdesign mhsdesign left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Marked the places that are different. Bastian and me made these changes together and i just re-reviewed them fully by diffing

git diff -U0 HEAD^ > ../myCurrent.diff and then replacing the noise from the diff and see whats left.

@@ -73,7 +73,6 @@ Feature: Behavior of Node timestamp properties "created", "originalCreated", "la
| workspaceName | "user-test" |
| baseWorkspaceName | "review" |
| newContentStreamId | "cs-user" |
| workspaceOwner | "some-user" |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fyi workspaceOwner used ... but no effect

@@ -44,7 +44,6 @@ Feature: Workspace rebasing - conflicting changes
| workspaceName | "user-test" |
| baseWorkspaceName | "live" |
| newContentStreamId | "user-cs-identifier" |
| workspaceOwner | "owner-identifier" |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fyi workspaceOwner used ... but no effect

@@ -44,7 +44,6 @@ Feature: Workspace based content publishing
| workspaceName | "user-test" |
| baseWorkspaceName | "live" |
| newContentStreamId | "user-cs-identifier" |
| workspaceOwner | "owner-identifier" |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.

@@ -44,7 +44,6 @@ Feature: Workspace discarding - basic functionality
| workspaceName | "user-test" |
| baseWorkspaceName | "live" |
| newContentStreamId | "user-cs-identifier" |
| workspaceOwner | "owner-identifier" |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.

@mhsdesign mhsdesign changed the title WIP TASK: Remove workspaceTitle, workspaceDescription and workspaceOwner use from behat core tests Oct 1, 2024
@mhsdesign mhsdesign marked this pull request as ready for review October 1, 2024 15:39
@github-actions github-actions bot added the Task label Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants