BUGFIX 4508 mark dependands of live outdated after direct change #5274
Conversation
| @@ -754,8 +753,6 @@ private function whenWorkspaceWasCreated(WorkspaceWasCreated $event): void | |||
| private function whenWorkspaceWasDiscarded(WorkspaceWasDiscarded $event): void | |||
| { | |||
| $this->updateWorkspaceContentStreamId($event->workspaceName, $event->newContentStreamId); | |||
| $this->markWorkspaceAsOutdated($event->workspaceName); | |||
There was a problem hiding this comment.
this markWorkspaceAsOutdated in discard seems to have been wrong. At least i makes no sense because we get a fresh cs.
| @@ -56,11 +55,13 @@ public function findWorkspaceByName(WorkspaceName $workspaceName): ?Workspace | |||
| { | |||
| $workspaceByNameStatement = <<<SQL | |||
| SELECT | |||
There was a problem hiding this comment.
should we deduplicate this logic using a querybuilder?
| {$this->tableNames->workspace()} ws | ||
| JOIN {$this->tableNames->contentStream()} cs ON cs.id = ws.currentcontentstreamid | ||
| LEFT JOIN {$this->tableNames->contentStream()} scs ON cs.sourceContentStreamId = scs.id |
There was a problem hiding this comment.
so the performance trait is this: we still have the status in the workspace, but we have to calculate it slightly more expensive with these two joins.
I cannot say if this is better performance than having on the write side a similar complex update logic for each event. But as findWorkspaceByName (and implicitly getContentGraph) trigger this query and are also part of the write side for constraint checks we have to carefully evaluate.
| | baseWorkspaceName | "shared" | | ||
| | newContentStreamId | "user-cs-two" | | ||
|
|
||
| Scenario: Changes to the root workspace render dependents outdated |
There was a problem hiding this comment.
this tests fails on 9.0-dev
FIXES: #4508
Upgrade instructions
Review instructions
Checklist
FEATURE|TASK|BUGFIX!!!and have upgrade-instructions