Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TASK: Use buildBasicNodeAggregateQuery in other query #5276

Open
wants to merge 2 commits into
base: 9.0
Choose a base branch
from
Open

TASK: Use buildBasicNodeAggregateQuery in other query #5276

wants to merge 2 commits into from

Commits on Oct 7, 2024

  1. TASK: Rename to buildBasicParentNodeAggregateQuery to fit naming sc… 

    …hema

Also i dont exactly understand how the methods are supposed to be named and work (when do we pass arguments or when to use `setParameters`) but because we dont return a final query i think it should be `buildBasicParentNodeAggregateQuery`
    @mhsdesign
    mhsdesign committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    dd460fe View commit details
    Browse the repository at this point in the history

  2. TASK: Use buildBasicNodeAggregateQuery in other query 

    `findParentNodeAggregateByChildOriginDimensionSpacePoint` can be simplified by using a utility.
    @mhsdesign
    mhsdesign committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    e83f9f5 View commit details
    Browse the repository at this point in the history