Skip to content

Commit

Permalink
refactor!: remove util.path.escape_wildcards
Browse files Browse the repository at this point in the history
Work on #2079.
  • Loading branch information
dundargoc committed Dec 14, 2024
1 parent 41e249e commit 3da1815
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 21 deletions.
11 changes: 5 additions & 6 deletions lua/lspconfig/util.lua
Original file line number Diff line number Diff line change
Expand Up @@ -97,10 +97,6 @@ end

-- Some path utilities
M.path = (function()
local function escape_wildcards(path)
return path:gsub('([%[%]%?%*])', '\\%1')
end

--- @param path string
--- @return boolean
local function is_fs_root(path)
Expand Down Expand Up @@ -179,7 +175,6 @@ M.path = (function()
local path_separator = iswin and ';' or ':'

return {
escape_wildcards = escape_wildcards,
is_absolute = is_absolute,
join = path_join,
traverse_parents = traverse_parents,
Expand Down Expand Up @@ -216,13 +211,17 @@ function M.get_lsp_clients(filter)
return nvim_eleven and lsp.get_clients(filter) or lsp.get_active_clients(filter)
end

local function escape_wildcards(path)
return path:gsub('([%[%]%?%*])', '\\%1')
end

function M.root_pattern(...)
local patterns = M.tbl_flatten { ... }
return function(startpath)
startpath = M.strip_archive_subpath(startpath)
for _, pattern in ipairs(patterns) do
local match = M.search_ancestors(startpath, function(path)
for _, p in ipairs(vim.fn.glob(M.path.join(M.path.escape_wildcards(path), pattern), true, true)) do
for _, p in ipairs(vim.fn.glob(M.path.join(escape_wildcards(path), pattern), true, true)) do
if vim.loop.fs_stat(p) then
return path
end
Expand Down
15 changes: 0 additions & 15 deletions test/lspconfig_spec.lua
Original file line number Diff line number Diff line change
Expand Up @@ -10,21 +10,6 @@ describe('lspconfig', function()

describe('util', function()
describe('path', function()
describe('escape_wildcards', function()
it('doesnt escape if not needed', function()
local lspconfig = require 'lspconfig'

local res = lspconfig.util.path.escape_wildcards '/usr/local/test/fname.lua'
eq('/usr/local/test/fname.lua', res)
end)
it('escapes if needed', function()
local lspconfig = require 'lspconfig'

local res = lspconfig.util.path.escape_wildcards '/usr/local/test/[sq brackets] fname?*.lua'
eq('/usr/local/test/\\[sq brackets\\] fname\\?\\*.lua', res)
end)
end)

describe('is_absolute', function()
it('is absolute', function()
local lspconfig = require 'lspconfig'
Expand Down

0 comments on commit 3da1815

Please sign in to comment.