Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare for Django 5.0 / Python3.12 compatibility #245

Merged

Conversation

protoroto
Copy link
Member

Description

Prepare for Django 5.0 / Python3.12 compatibility

References

Fix #244

Checklist

  • I have read the contribution guide
  • Code lint checked via inv lint
  • changes file included (see docs)
  • Usage documentation added in case of new features
  • Tests added

@protoroto protoroto requested a review from yakky October 25, 2023 13:32
@codecov
Copy link

codecov bot commented Oct 25, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (363b919) 92.23% compared to head (6ff15bc) 92.24%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #245   +/-   ##
========================================
  Coverage    92.23%   92.24%           
========================================
  Files           10       10           
  Lines          798      799    +1     
  Branches       126      126           
========================================
+ Hits           736      737    +1     
  Misses          24       24           
  Partials        38       38           
Flag Coverage Δ
unittests 92.24% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@protoroto protoroto force-pushed the feature/issue-244-add-django5.0-python3.12-compatibility branch 6 times, most recently from 6b93701 to fef8f6b Compare October 26, 2023 07:04
app_helper/utils.py Outdated Show resolved Hide resolved
tox.ini Outdated Show resolved Hide resolved
@protoroto protoroto force-pushed the feature/issue-244-add-django5.0-python3.12-compatibility branch 2 times, most recently from 2a3539f to a0acd78 Compare October 31, 2023 08:17
@protoroto protoroto force-pushed the feature/issue-244-add-django5.0-python3.12-compatibility branch from a0acd78 to f0d2bc1 Compare November 27, 2023 17:15
@protoroto protoroto requested a review from yakky November 28, 2023 08:44
@protoroto protoroto merged commit 77bbf2f into develop Nov 28, 2023
130 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Check Django5.0 / Python 3.12 compatibility
2 participants