Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump faster-hex to v0.8.2 #40

Merged
merged 2 commits into from
Nov 22, 2023

Conversation

eval-exec
Copy link
Collaborator

@eval-exec eval-exec commented Nov 19, 2023

We need to publish a new version of faster-hex

@eval-exec
Copy link
Collaborator Author

CI failed, #41 fixed that.

@eval-exec
Copy link
Collaborator Author

Rebased on master.

@zhangsoledad zhangsoledad added this pull request to the merge queue Nov 22, 2023
Merged via the queue into nervosnetwork:master with commit e50bc72 Nov 22, 2023
4 of 5 checks passed
@l-wegner
Copy link

Hi,

I just wanted to mention, that this version contains kind of a breaking change by extending the error enum.

This crate does not compile anymore: https://crates.io/crates/gix-hash/0.13.1/dependencies.

Maybe releasing it as v0.9.0 is better and recreate v0.8.1?

@eval-exec
Copy link
Collaborator Author

Hi,

I just wanted to mention, that this version contains kind of a breaking change by extending the error enum.

This crate does not compile anymore: https://crates.io/crates/gix-hash/0.13.1/dependencies.

Maybe releasing it as v0.9.0 is better and recreate v0.8.1?

Sorry, I have yanked v0.8.2, going to release v0.9.0

@l-wegner
Copy link

Thank you very much. Solved my issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants