Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CI #50

Merged
merged 1 commit into from
Sep 13, 2024
Merged

Fix CI #50

merged 1 commit into from
Sep 13, 2024

Conversation

Georges760
Copy link
Contributor

remove the hacky easimon/maximize-build-space which cause the CI to fail, don't really need it

eval-exec
eval-exec approved these changes Sep 13, 2024
View reviewed changes
Copy link
Collaborator

@eval-exec eval-exec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, I think this PR and #49 can be merged @zhangsoledad

@eval-exec
Copy link
Collaborator

eval-exec commented Sep 13, 2024 •
edited
Loading

Hello @quake, do you have the privilege to merge this PR?

@eval-exec eval-exec requested a review from quake September 13, 2024 11:47
@quake quake added this pull request to the merge queue Sep 13, 2024
Merged via the queue into nervosnetwork:master with commit 761d84a Sep 13, 2024
5 checks passed
@Georges760 Georges760 deleted the ci-fix branch September 13, 2024 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eval-exec eval-exec eval-exec approved these changes

@quake quake Awaiting requested review from quake

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Georges760 @eval-exec @quake