Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade dev-dependency criterion to 0.4, bump faster-hex to 0.10.0 #52

Merged
merged 2 commits into from
Sep 14, 2024

Conversation

eval-exec
Copy link
Collaborator

@eval-exec eval-exec commented Sep 14, 2024

  • bump faster-hex to 0.10.0
  • Upgrade criterion to 0.4 to fix:
❯ cargo deny check --hide-inclusion-graph --show-stats advisories sources
2024-09-14 05:10:37 [WARN] unable to find a config path, falling back to default config
error[unsound]: Potential unaligned read
  ┌─ /home/exec/Projects/github.com/nervosnetwork/faster-hex/Cargo.lock:1:1
  │
1 │ atty 0.2.14 registry+https://github.com/rust-lang/crates.io-index
  │ ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ unsound advisory detected
  │
  ├ ID: RUSTSEC-2021-0145
  ├ Advisory: https://rustsec.org/advisories/RUSTSEC-2021-0145
  ├ On windows, `atty` dereferences a potentially unaligned pointer.

    In practice however, the pointer won't be unaligned unless a custom global allocator is used.

    In particular, the `System` allocator on windows uses `HeapAlloc`, which guarantees a large enough alignment.

    # atty is Unmaintained

    A Pull Request with a fix has been provided over a year ago but the maintainer seems to be unreachable.

    Last release of `atty` was almost 3 years ago.

    ## Possible Alternative(s)

    The below list has not been vetted in any way and may or may not contain alternatives;

     - [std::io::IsTerminal](https://doc.rust-lang.org/stable/std/io/trait.IsTerminal.html) - Stable since Rust 1.70.0
     - [is-terminal](https://crates.io/crates/is-terminal) - Standalone crate supporting Rust older than 1.70.0
  ├ Announcement: https://github.com/softprops/atty/issues/50
  ├ Solution: No safe upgrade is available!

error[unmaintained]: serde_cbor is unmaintained
   ┌─ /home/exec/Projects/github.com/nervosnetwork/faster-hex/Cargo.lock:66:1

66 │ serde_cbor 0.11.2 registry+https://github.com/rust-lang/crates.io-index
   │ ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ unmaintained advisory detected

   ├ ID: RUSTSEC-2021-0127
   ├ Advisory: https://rustsec.org/advisories/RUSTSEC-2021-0127
   ├ The `serde_cbor` crate is unmaintained. The author has archived the github repository.

     Alternatives proposed by the author:

      * [`ciborium`](https://crates.io/crates/ciborium)
      * [`minicbor`](https://crates.io/crates/minicbor)
   ├ Announcement: https://github.com/pyfisch/cbor
   ├ Solution: No safe upgrade is available!

 advisories FAILED: 2 errors, 0 warnings, 0 notes
        sources ok: 0 errors, 0 warnings, 0 notes

@eval-exec eval-exec changed the title Upgrade dev-dependency criterion to 0.5, bump faster-hex to 0.10.0 Upgrade dev-dependency criterion to 0.4, bump faster-hex to 0.10.0 Sep 14, 2024
@quake quake added this pull request to the merge queue Sep 14, 2024
Merged via the queue into nervosnetwork:master with commit 44543a9 Sep 14, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants