-
Notifications
You must be signed in to change notification settings - Fork 370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Travis build on OSX #1183
Travis build on OSX #1183
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Many thanks providing this extremely useful addition. I have a more structural change request and a suggestion for the wording of a comment. Other than that I'm happy to approve once the Travis run is finished.
I observe exactly the same hang of the MPI testsuite with Open MPI 3.1.3 on Linux. As it sometimes works without problems, I suggest some race condition going on. We really should fix our data exchange in the MPI based testing with SLI. For now, I'm fine with just disabling it here, although I think @heplesser should also have a look. |
Co-Authored-By: lekshmideepu <lekshmideepu@users.noreply.github.com>
…ags and libraries
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Many thanks for addressing my comments. I think this really is a huge step forward for us and I'm all in favor of merging it.
@tammoippen, would you be available to review this PR? Thanks! |
Co-Authored-By: Tammo Ippen <tammo.ippen@posteo.de>
Co-Authored-By: Tammo Ippen <tammo.ippen@posteo.de>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice. The gcc selection will break for the next major release, but until then we have some time. Should probably be something like:
grep '^/usr/local/bin/gcc-\d+$
Best.
Awesome. I'm merging. I'd also like to thank @tammoippen for reviewing @lekshmideepu for putting so much hard work into this - the punishment is over ;-) |
:-) Thanks @jougs |
I am happy to assist 😄 |
Added the best possible maximal build for OSX Mojave which fixes #639
MUSIC is turned OFF due to the non-availability of MPI-CXX bindings in Openmpi4.0.1 (Refer INCF/MUSIC#27 (comment)).
Fixes the incorrect nest.init call #1181 and module import error mentioned in #1180