Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes: #18203 - Validate that scope is selected if scope type is specified #18254

Merged
merged 3 commits into from
Dec 30, 2024

Conversation

bctiemann
Copy link
Contributor

Fixes: #18203

On models with CachedScopeMixin (Prefix, Cluster, WirelessLAN), ensure that if a ScopeType is specified in the create or edit form, a Scope must also be selected. This prevents a spurious error being raised: 'PrefixForm' has no field named 'scope_id'.

@bctiemann bctiemann changed the base branch from develop to feature December 17, 2024 23:03
@bctiemann bctiemann requested a review from arthanson December 17, 2024 23:03
@jeremystretch jeremystretch added the beta Concerns a bug/feature in a beta release label Dec 27, 2024
@jeremystretch jeremystretch merged commit 0cda10a into feature Dec 30, 2024
6 checks passed
@jeremystretch jeremystretch deleted the 18203-scope-type-without-scope branch December 30, 2024 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beta Concerns a bug/feature in a beta release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Graceful error handling for selecting a scope type without a specific scope instance
2 participants