Added support for Interactive reply buttons media header #212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aalbarca
reviewed
Dec 4, 2024
| $header = new TextHeader($header); | ||
| } | ||
|
|
||
| if (!$header instanceof ButtonHeader && $header !== null) { |
There was a problem hiding this comment.
this if is not necessary, should you use type hinting in the function:
public function sendButton(string $to, string $body, ButtonAction $action, ?string | ?ButtonHeader $header = null, ?string $footer = null): Response
aalbarca
requested changes
Dec 4, 2024
|
|
||
| class ButtonReplyMessage extends Message | ||
| final class ButtonReplyMessage extends Message |
There was a problem hiding this comment.
The class ButtonReplyMEssage yet exists in previous versions so you cannot convert it to final class because this is a breaking change (if anyone extended this class in our code you'll be breaking it)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes support for button reply media headers (image, video, documents).
It maintains existing text header usage without breaking the code by simply swapping the current text header to an instance of a Text Button Reply Header class.
Reference: https://developers.facebook.com/docs/whatsapp/cloud-api/messages/interactive-reply-buttons-messages/