Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

internal users API #7

Merged
merged 9 commits into from
Dec 5, 2024
Merged

internal users API #7

merged 9 commits into from
Dec 5, 2024

Conversation

jenrik
Copy link
Contributor

@jenrik jenrik commented Dec 4, 2024

Add functions to Create, Read, Update and Delete internal users in tidydns.

Additionally some miscellaneous cleanup have been performed.

@jenrik jenrik requested a review from hatrx December 4, 2024 10:24
Copy link

@hatrx hatrx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only some minor cosmetic comments. I assuming the code is tested and does what it says. Looks good to me :)

pkg/tidydns/tidydns.go Show resolved Hide resolved
pkg/tidydns/tidydns.go Show resolved Hide resolved
pkg/tidydns/tidydns.go Outdated Show resolved Hide resolved
pkg/tidydns/tidydns.go Outdated Show resolved Hide resolved
pkg/tidydns/tidydns.go Outdated Show resolved Hide resolved
pkg/tidydns/tidydns.go Show resolved Hide resolved
pkg/tidydns/tidydns_test.go Show resolved Hide resolved
pkg/tidydns/tidydns.go Outdated Show resolved Hide resolved
@jenrik jenrik force-pushed the feature/internal-users-api branch from 9ab4bf4 to f3e8970 Compare December 4, 2024 13:36
@jenrik jenrik merged commit 21c942b into main Dec 5, 2024
1 check passed
@jenrik jenrik deleted the feature/internal-users-api branch December 5, 2024 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants