chore: update template to use Remix Vite and latest Hydrogen #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remix sites can either use Remix Vite (now the default) or the Remix "Classic Compiler". Hydrogen sites have supported Remix Vite since ~April 2024 and this is now the default for Hydrogen sites. This updates the Netlify template to use Remix Vite. It also updates it to the latest version of Hydrogen and pulls in upstream updates to the core Hydrogen template.
I must have pulled the base template while it was in a broken state? The latest version has this broken code removed.
serhalp
changed the title
serhalp
commented
Sep 5, 2024
| "build": "remix build", | ||
| "dev": "remix dev --manual -c \"netlify dev\"", | ||
| "preview": "netlify serve", | ||
| "build": "remix vite:build", |
There was a problem hiding this comment.
We can't use shopify hydrogen build here because of Shopify/hydrogen#2497.
pieh
approved these changes
Sep 5, 2024
serhalp
deleted the
serhalp/frp-1268-update-hydrogen-template-to-use-remix-vite
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remix sites can either use Remix Vite (now the default) or the Remix "Classic Compiler".
Hydrogen sites have supported Remix Vite since ~April 2024 and this is now the default for Hydrogen sites.
This updates the Netlify template to use Remix Vite.
It also updates it to the latest version of Hydrogen and pulls in upstream updates to the core Hydrogen template.
Here is a deploy preview I created manually while linked to netlify/remix-compute#441: https://66d9c7bf9f3d281e3f257317--hydrogen-remix-template.netlify.app/.
To review this PR, you can ignore
app/routes,app/components,app/styles,app/graphql, andapp/lib. Those are untouched from the base Hydrogen template.To do