testing fix flakyness of sig_reload AT

Also convert it to a bazel test.

acceptance/sig_reload/BUILD.bazel

@@ -0,0 +1,80 @@
+load("@io_bazel_rules_docker//container:container.bzl", "container_bundle")
+load("@rules_python//python:defs.bzl", "py_test")
+load("@pip3_deps//:requirements.bzl", "requirement")
+load("//python/topology:topology.bzl", "topology")
+
+py_library(
+    name = "test_lib",
+    srcs = ["test.py"],
+    data = [
+        ":sig_topo",
+        ":testcontainers.tar",
+    ],
+    deps = [
+        requirement("plumbum"),
+        "//acceptance/common:base",
+        "//acceptance/common:log",
+        "//acceptance/common:scion",
+        "//acceptance/common:tools",
+    ],
+)
+
+py_binary(
+    name = "test_setup",
+    srcs = ["test.py"],
+    args = ["setup"],
+    main = "test.py",
+    deps = [":test_lib"],
+)
+
+py_binary(
+    name = "test_run",
+    srcs = ["test.py"],
+    args = [
+        "run",
+        "--sig_acceptance",
+        "$(location //go/acceptance/sig_ping_acceptance)",
+    ],
+    data = ["//go/acceptance/sig_ping_acceptance"],
+    main = "test.py",
+    deps = [":test_lib"],
+)
+
+py_binary(
+    name = "test_teardown",
+    srcs = ["test.py"],
+    args = ["teardown"],
+    main = "test.py",
+    deps = [":test_lib"],
+)
+
+py_test(
+    name = "test",
+    size = "large",
+    srcs = ["test.py"],
+    args = [
+        "--sig_acceptance",
+        "$(location //go/acceptance/sig_ping_acceptance)",
+    ],
+    data = ["//go/acceptance/sig_ping_acceptance"],
+    deps = [":test_lib"],
+)
+
+container_bundle(
+    name = "testcontainers",
+    images = {
+        "control:latest": "//docker:control_prod",
+        "daemon:latest": "//docker:daemon_prod",
+        "dispatcher:latest": "//docker:dispatcher_prod",
+        "posix-gateway:latest": "//docker:posix_gateway_prod",
+        "posix-router:latest": "//docker:posix_router_prod",
+        "tester:latest": "//docker:tester",
+    },
+)
+
+topology(
+    name = "sig_topo",
+    src = "//topology:tiny4.topo",
+    out = "gen.tar",
+    sig = True,
+)

acceptance/sig_reload/test.py

@@ -0,0 +1,153 @@
+#!/usr/bin/env python3
+
+# Copyright 2020 Anapaya Systems
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+import json
+import logging
+import time
+
+import plumbum
+from plumbum import cmd
+
+from acceptance.common import base
+from acceptance.common import log
+from acceptance.common import tools
+from acceptance.common import scion
+
+
+base.set_name(__file__)
+logger = logging.getLogger(__name__)
+
+
+class Test(base.TestBase):
+    """
+    Tests that reloading the traffic json configuration correctly works in the
+    Gateway.
+    """
+    sig_acceptance = plumbum.cli.SwitchAttr("sig_acceptance", str,
+                                            default="./bin/sig_ping_acceptance",
+                                            help="The sig_ping_acceptance binary" +
+                                            " (default: ./bin/sig_ping_acceptance)")
+
+    def main(self):
+        print("artifacts dir: %s" % self.test_state.artifacts)
+        self._unpack_topo()
+        if not self.nested_command:
+            try:
+                self._setup()
+                self._run()
+            finally:
+                self._teardown()
+
+    def _unpack_topo(self):
+        # Unpack the topogen output, adapt SCIONROOT.
+        cmd.tar("-xf", "./acceptance/sig_reload/gen.tar",
+                "-C", self.test_state.artifacts)
+        cmd.sed("-i", "s#$SCIONROOT#%s#g" % self.test_state.artifacts,
+                self.test_state.artifacts / "gen/scion-dc.yml")
+
+    def _docker_compose(self, *args) -> str:
+        return cmd.docker_compose("-f", self.test_state.artifacts / "gen" / "scion-dc.yml",
+                                  "-p", "scion", *args)
+
+    def _setup(self):
+        # First load the images
+        print(cmd.docker("image", "load", "-i",
+              "./acceptance/sig_reload/testcontainers.tar"))
+
+        # Start the topology, wait for everything to be ready.
+        print(self._docker_compose("up", "-d"))
+        # Give some time, so revocation can be gone.
+        print("wait for topology to be ready")
+        time.sleep(30)
+        print(self._docker_compose("ps"))
+        print("setup done")
+
+    def _run(self):
+        ping_test = plumbum.local[self.sig_acceptance]
+
+        src_ia = "1-ff00:0:111"
+        dst_ia = "1-ff00:0:112"
+
+        print("Running ping test")
+        print(ping_test("-d", "-outDir", self.test_state.artifacts, "-src", src_ia, "-dst", dst_ia))
+        print("Ping done")
+
+        print("Remove 1-ff00:0:112 from remotes")
+        remote_cfg = self._pop_remote(dst_ia)
+        print("Running ping test")
+        print(ping_test("-d", "-outDir", self.test_state.artifacts, "-src", src_ia, "-dst", dst_ia,
+                        "-fail"))
+
+        print("Restore remote")
+        self._put_remote(dst_ia, remote_cfg)
+        print("Running ping test")
+        print(ping_test("-d", "-outDir", self.test_state.artifacts, "-src", src_ia, "-dst", dst_ia))
+        print("Ping done")
+
+    def _teardown(self):
+        logs = self._docker_compose("logs")
+        with open(self.test_state.artifacts / "logs" / "docker-compose.log", "w") as f:
+            f.write(logs)
+        print(self._docker_compose("down", "-v"))
+
+    def _pop_remote(self, dst_ia: str):
+        with open(self.test_state.artifacts / "gen" / "ASff00_0_111" / "sig.json", "r+") as f:
+            cfg = json.load(f)
+            res = cfg["ASes"].pop(dst_ia, None)
+            f.seek(0)
+            json.dump(cfg, f, indent=2)
+            f.truncate()
+        self._docker_compose("kill", "-s", "SIGHUP", "scion_sig_1-ff00_0_111")
+        time.sleep(4)
+        return res
+
+    def _put_remote(self, dst_ia: str, remote_cfg):
+        with open(self.test_state.artifacts / "gen" / "ASff00_0_111" / "sig.json", "r+") as f:
+            cfg = json.load(f)
+            res = cfg["ASes"][dst_ia] = remote_cfg
+            f.seek(0)
+            json.dump(cfg, f, indent=2)
+            f.truncate()
+        self._docker_compose("kill", "-s", "SIGHUP", "scion_sig_1-ff00_0_111")
+        time.sleep(4)
+        return res
+
+
+@Test.subcommand("setup")
+class TestSetup(Test):
+
+    def main(self):
+        self._setup()
+
+
+@Test.subcommand("run")
+class TestRun(Test):
+
+    def main(self):
+        self._run()
+
+
+@Test.subcommand("teardown")
+class TestTeardown(Test):
+
+    def main(self):
+        self._teardown()
+
+
+if __name__ == "__main__":
+    log.init_log()
+    Test.test_state = base.TestState(scion.SCIONDocker(), tools.DC())
+    Test.run()