Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Pipeline catalog is now inside the container but still not found by the CLI #375

Closed
1 task done
michellewang opened this issue Nov 5, 2024 · 1 comment · Fixed by #379
Closed
1 task done
Assignees
Labels
released This issue/pull request has been released.

Comments

@michellewang
Copy link

michellewang commented Nov 5, 2024

Is there an existing issue for this?

  • I have searched the existing issues

Expected Behavior

No response

Current Behavior

  • Inside the container, the pipeline catalog is in /app/src/pipeline-catalog, thanks to [FIX] Make pipeline-catalog submodule available to built Docker image #373
  • This does not match the value in bagel.mappings.PROCESSING_PIPELINE_PATH, which points to /usr/local/lib/python3.10/site-packages/pipeline-catalog/processing
  • This is because PROCESSING_PIPELINE_PATH is built from the file at /usr/local/lib/python3.10/site-packages/bagel/mappings.py, which is part of the installed Python package, not the source code
  • So I think this is more of a packaging problem, not a Docker-building problem. A solution would be to move the pipeline-catalog submodule inside the bagel directory. Or there could be a script that generates a static JSON file from the pipeline catalog and stores it inside the bagel directory, then at runtime that JSON file could be loaded into KNOWN_PIPELINE_URIS directly. A third possible solution would be to configure pyproject.toml to somehow include the pipeline catalog, but I'm not sure how to do that and also that might not guarantee that PROCESSING_PIPELINE_PATH will still point to the correct directory.

Error message

No response

Environment

bagelcli v0.3.2

How to reproduce

No response

Anything else?

No response

@michellewang michellewang added the type:bug Defects in shipped code and fixes for those defects label Nov 5, 2024
@alyssadai alyssadai moved this to Implement - Active in Neurobagel Nov 6, 2024
@alyssadai alyssadai self-assigned this Nov 6, 2024
@alyssadai alyssadai removed the type:bug Defects in shipped code and fixes for those defects label Nov 7, 2024
@github-project-automation github-project-automation bot moved this from Review - Active to Review - Done in Neurobagel Nov 7, 2024
Copy link
Contributor

neurobagel-bot bot commented Nov 7, 2024

🚀 Issue was released in v0.3.3 🚀

@neurobagel-bot neurobagel-bot bot added the released This issue/pull request has been released. label Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released This issue/pull request has been released.
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants