-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FIX] Package pipeline-catalog
as data files in CLI installation
#379
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #379 +/- ##
==========================================
- Coverage 98.37% 98.37% -0.01%
==========================================
Files 16 16
Lines 983 982 -1
==========================================
- Hits 967 966 -1
Misses 16 16 ☔ View full report in Codecov by Sentry. |
Pull Request Test Coverage Report for Build 11709023670Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @alyssadai for fixing this.
I understand that my guess of dev-mode install didn't fix it, so having a test here that would have caught the original bug is tricky. So let's do this: let's merge the fix without the test, but please create an issue to find a way to run the tests on the installed package. My guess is that the CLIRunner we use to "call" the CLI as if we used it from the command line is the limitation here, but I'm sure there is a way to force it to run on the installed CLI (even something silly like making an actual system call with subprocess or something - but I'm sure something smarter must exist too).
In any case: thanks for the fix 🧑🍳
🚀 PR was released in |
Changes proposed in this pull request:
pipeline-catalog
submodule moved intobagel
module so that it ends up inside the package directory after installationpipeline-catalog
wouldn't be automatically included in the installation since it's not a module (no__init__.py
), so we additionally must update the package config file to include this subdirectory as additional package databagel
module, and test data submodules (neurobagel_examples
,bids-examples
) moved undertests/
Checklist
This section is for the PR reviewer
[ENH]
,[FIX]
,[REF]
,[TST]
,[CI]
,[MNT]
,[INF]
,[MODEL]
,[DOC]
) (see our Contributing Guidelines for more info)skip-release
(to be applied by maintainers only)Closes #XXXX
For new features:
For bug fixes: