Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REF] Refactor phenotypic/BIDS subjects check and add more intermediate stdout for bagel bids #227

Merged
merged 5 commits into from
Oct 23, 2023

Conversation

alyssadai
Copy link
Contributor

@alyssadai alyssadai commented Oct 21, 2023

Closes #190

Changes proposed in this pull request:

  • Check for BIDS subject IDs missing from the phenotypic JSONLD before slow BIDSLayout initialization
  • Print more intermediate messages during bagel bids command to indicate program progress

Checklist

  • PR has an interpretable title with a prefix ([ENH], [FIX], [REF], [TST], [CI], [MNT], [INF], [MODEL], [DOC]) (see https://neurobagel.org/contributing/pull_requests for more info)
  • PR links to GitHub issue with mention Closes #XXXX
  • Tests pass
  • Checks pass

For new features:

  • Tests have been added

For bug fixes:

  • There is at least one test that would fail under the original bug conditions.

@github-actions
Copy link

github-actions bot commented Oct 21, 2023

Pull Request Test Coverage Report for Build 6601724770

  • 30 of 30 (100.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.006%) to 99.685%

Totals Coverage Status
Change from base Build 6579716968: 0.006%
Covered Lines: 1267
Relevant Lines: 1271

💛 - Coveralls

@alyssadai alyssadai marked this pull request as ready for review October 22, 2023 04:40
@rmanaem rmanaem self-requested a review October 23, 2023 17:13
Copy link
Contributor

@rmanaem rmanaem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧑‍🍳

@alyssadai alyssadai merged commit 6763e09 into main Oct 23, 2023
6 checks passed
@alyssadai alyssadai deleted the iss-190/refactor-subject-overlap-check branch October 23, 2023 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Check that all BIDS subjects are in pheno.jsonld prior to BIDS parsing
2 participants