Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Build docker image on release #252

Closed
wants to merge 2 commits into from
Closed

[CI] Build docker image on release #252

wants to merge 2 commits into from

Conversation

surchs
Copy link
Contributor

@surchs surchs commented Dec 13, 2023

Changes proposed in this pull request:

So far, we only made releases with auto. However because the release is done by a bot, this will not trigger our "release-published" hook that we rely on to build and push our docker images. So this PR

  • builds and pushes the docker image directly inside of the release workflow (could also be a separate workflow that is just called from there)
  • gets the release version and tags the docker image with it
  • removes the old (on release) docker build workflow

Checklist

  • PR has an interpretable title with a prefix ([ENH], [FIX], [REF], [TST], [CI], [MNT], [INF], [MODEL], [DOC]) (see https://neurobagel.org/contributing/pull_requests for more info)
  • PR links to GitHub issue with mention Closes #XXXX
  • Tests pass
  • Checks pass

For new features:

  • Tests have been added

For bug fixes:

  • There is at least one test that would fail under the original bug conditions.

Copy link

github-actions bot commented Dec 13, 2023

Pull Request Test Coverage Report for Build 7197611936

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 99.696%

Totals Coverage Status
Change from base Build 7186566544: 0.0%
Covered Lines: 1311
Relevant Lines: 1315

💛 - Coveralls

@surchs
Copy link
Contributor Author

surchs commented Dec 13, 2023

Closing in favour of the steps outlined here: neurobagel/planning#64

@surchs surchs closed this Dec 13, 2023
@surchs surchs deleted the add_release_build branch December 13, 2023 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant