Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Switch to parallel build config for coveralls #263

Merged
merged 1 commit into from
Dec 19, 2023

Conversation

alyssadai
Copy link
Contributor

@alyssadai alyssadai commented Dec 19, 2023

Changes proposed in this pull request:

Checklist

  • PR has an interpretable title with a prefix ([ENH], [FIX], [REF], [TST], [CI], [MNT], [INF], [MODEL], [DOC]) (see https://neurobagel.org/contributing/pull_requests for more info)
  • PR links to GitHub issue with mention Closes #XXXX
  • Tests pass
  • Checks pass

For new features:

  • Tests have been added

For bug fixes:

  • There is at least one test that would fail under the original bug conditions.

@alyssadai alyssadai requested a review from surchs December 19, 2023 17:09
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b66b9ee) 97.86% compared to head (ba02970) 97.86%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #263   +/-   ##
=======================================
  Coverage   97.86%   97.86%           
=======================================
  Files          13       13           
  Lines         703      703           
=======================================
  Hits          688      688           
  Misses         15       15           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 7265175264

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 99.696%

Totals Coverage Status
Change from base Build 7252899380: 0.0%
Covered Lines: 1311
Relevant Lines: 1315

💛 - Coveralls

Copy link
Contributor

@surchs surchs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧑‍🍳 very nice!

@alyssadai alyssadai merged commit 3b24e33 into main Dec 19, 2023
9 checks passed
@alyssadai alyssadai deleted the setup-coveralls-parallel branch December 19, 2023 17:25
@surchs
Copy link
Contributor

surchs commented Jan 8, 2024

🚀 PR was released in v0.2.1 🚀

@surchs surchs added the released This issue/pull request has been released. label Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Investigate Coveralls failure about "parallel builds"
4 participants