-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REF] Upgrade codebase to Pydantic>2 #389
Conversation
- now required to prevent error: pydantic.errors.PydanticUserError: Field 'schemaKey' defined on a base class was overridden by a non-annotated attribute. All field definitions, including overrides, require a type annotation.
- pydantic v2 HttpUrl no longer requires it
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #389 +/- ##
==========================================
- Coverage 98.36% 98.36% -0.01%
==========================================
Files 21 18 -3
Lines 980 977 -3
==========================================
- Hits 964 961 -3
Misses 16 16 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
Pull Request Test Coverage Report for Build 11849787896Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @alyssadai, that's awesome. Very nice that we can finally close this!
Everything looks nice, left some comments, but 🧑🍳
Co-authored-by: Sebastian Urchs <surchs@users.noreply.github.com>
🚀 PR was released in |
Changes proposed in this pull request:
generate_context()
using more standard methods to accommodate changes to Pydantic internalsDataFrame.applymap
to suppress deprecation warningspip-compile
)Checklist
This section is for the PR reviewer
[ENH]
,[FIX]
,[REF]
,[TST]
,[CI]
,[MNT]
,[INF]
,[MODEL]
,[DOC]
) (see our Contributing Guidelines for more info)skip-release
(to be applied by maintainers only)Closes #XXXX
For new features:
For bug fixes: