-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MNT] Deprecate Cognitive Atlas vocab namespace & add check for unsupported namespaces #410
base: main
Are you sure you want to change the base?
Conversation
- example5 previously wasn't used anywhere and was conceptually a duplicate of example9
Reviewer's Guide by SourceryThis PR implements a validation mechanism for vocabulary namespace prefixes in data dictionaries, deprecating the Cognitive Atlas (cogatlas) namespace and adding checks to ensure only supported namespaces are used. The implementation includes error handling with informative messages for both unsupported and deprecated namespaces. No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #410 +/- ##
==========================================
+ Coverage 98.49% 98.54% +0.04%
==========================================
Files 18 18
Lines 1066 1101 +35
==========================================
+ Hits 1050 1085 +35
Misses 16 16 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @alyssadai, this looks great.
I do think the generate_neurobagel_examples workflow would be better handled via a makefile to reduce potential for mistakes. Leave it up to you if you want to handle that here or in a follow-on PR.
After you decide: 🧑🍳
Co-authored-by: Sebastian Urchs <surchs@users.noreply.github.com>
Waiting to merge (to release) along with neurobagel/annotation_tool#630. |
Hey @alyssadai I think we're ready to merge. Do you want me to start the annotation tool release? |
@surchs - do we want to wait for the related API PR from neurobagel/api#390? |
Aha, good point, I missed that. Yes, let's wait for that one |
Changes proposed in this pull request:
neurobagel_examples
submodule so tests passneurobagel_examples
(script added in this repo b/c the files usually need to be updated right away after CLI changes)Checklist
This section is for the PR reviewer
[ENH]
,[FIX]
,[REF]
,[TST]
,[CI]
,[MNT]
,[INF]
,[MODEL]
,[DOC]
) (see our Contributing Guidelines for more info)skip-release
(to be applied by maintainers only)Closes #XXXX
For new features:
For bug fixes:
Summary by Sourcery
Deprecate the Cognitive Atlas vocabulary namespace and add a mechanism to check for unsupported namespaces in data dictionaries. Update example5 to illustrate unsupported namespace usage and add corresponding tests to validate the new functionality.
Enhancements:
Tests:
Chores: